Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-10 Thread Xu, Guangxin
> -Original Message- > From: ffmpeg-devel On Behalf Of Xu, > Guangxin > Sent: Tuesday, March 9, 2021 5:13 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame >

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-10 Thread Michael Niedermayer
On Mon, Mar 08, 2021 at 11:36:00PM -0300, James Almer wrote: > In addition to the fact that av_image_copy() cannot handle hardware pixel > formats, h->short_ref[0]->f may not even be writable at this point. > > Based on a patch by Hendrik Leppkes. > > Signed-off-by: James Almer > --- > This is a

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-09 Thread Xu, Guangxin
; From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Tuesday, March 9, 2021 3:44 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame > data during error concealment > > O

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-08 Thread Hendrik Leppkes
On Tue, Mar 9, 2021 at 3:39 AM James Almer wrote: > > In addition to the fact that av_image_copy() cannot handle hardware pixel > formats, h->short_ref[0]->f may not even be writable at this point. > > Based on a patch by Hendrik Leppkes. > > Signed-off-by: James Almer > --- > This is an alternat

[FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-08 Thread James Almer
In addition to the fact that av_image_copy() cannot handle hardware pixel formats, h->short_ref[0]->f may not even be writable at this point. Based on a patch by Hendrik Leppkes. Signed-off-by: James Almer --- This is an alternative to "avcodec/h264_slice: properly handle missing reference frame