Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-24 Thread James Zern
On Fri, Dec 21, 2018 at 7:38 PM James Zern wrote: > > On Fri, Dec 21, 2018 at 1:36 PM Rene Claus > wrote: > > > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Signed-off-by: Rene Claus > > --- > >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 11:24 AM James Almer wrote: > > On 12/21/2018 1:09 PM, James Zern wrote: > > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus > > wrote: > >> > >> This commit adds configuration options to libvpxenc.c that can be used to > >> tune the sharpness parameter for VP8 and VP9. > >> >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 1:36 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread Rene Claus
This commit adds configuration options to libvpxenc.c that can be used to tune the sharpness parameter for VP8 and VP9. Signed-off-by: Rene Claus --- doc/encoders.texi | 4 libavcodec/libvpxenc.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Almer
On 12/21/2018 1:09 PM, James Zern wrote: > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus > wrote: >> >> This commit adds configuration options to libvpxenc.c that can be used to >> tune the sharpness parameter for VP8 and VP9. >> >> Signed-off-by: Rene Claus >> --- >> doc/encoders.texi | 4

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Thu, Dec 20, 2018 at 7:51 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-20 Thread Rene Claus
This commit adds configuration options to libvpxenc.c that can be used to tune the sharpness parameter for VP8 and VP9. Signed-off-by: Rene Claus --- doc/encoders.texi | 4 libavcodec/libvpxenc.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread James Zern
On Wed, Dec 19, 2018 at 2:03 PM James Almer wrote: > > On 12/19/2018 6:52 PM, Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Signed-off-by: Rene Claus > > --- > > doc/encoders.texi |

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread Rene Claus
Yes, setting it to zero is the same as not setting it at all. I'll look into updating vp8cx.h On Wed, Dec 19, 2018 at 2:03 PM James Almer wrote: > On 12/19/2018 6:52 PM, Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread James Almer
On 12/19/2018 6:52 PM, Rene Claus wrote: > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files changed, 10

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread Rene Claus
This commit adds configuration options to libvpxenc.c that can be used to tune the sharpness parameter for VP8 and VP9. Signed-off-by: Rene Claus --- doc/encoders.texi | 4 libavcodec/libvpxenc.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/doc/encoders.texi

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread Moritz Barsnick
On Wed, Dec 19, 2018 at 10:24:29 -0800, Rene Claus wrote: > +if (ctx->sharpness >= 0) Can this ever be untrue? Because: > +{ "sharpness", "Sharpness", OFFSET(sharpness), AV_OPT_TYPE_INT, > {.i64 = 0}, 0, 7, VE},

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread James Zern
On Wed, Dec 19, 2018 at 10:24 AM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter of the loop filter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 5

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread Rene Claus
This commit adds configuration options to libvpxenc.c that can be used to tune the sharpness parameter of the loop filter for VP8 and VP9. Signed-off-by: Rene Claus --- doc/encoders.texi | 4 libavcodec/libvpxenc.c | 5 + 2 files changed, 9 insertions(+) diff --git