Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-11-15 Thread James Almer
On 11/2/2018 8:57 PM, Chris Cunningham wrote: >> Also, when dealing with a super frame, to get other values like pixel >> format and frame dimensions we'd have to make sure to parse the visible >> frame, and if it's an inter frame also keep the reference frames around >> to take said values from

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-11-12 Thread Chris Cunningham
On Fri, Nov 2, 2018 at 4:57 PM Chris Cunningham wrote: > > Also, when dealing with a super frame, to get other values like pixel > > format and frame dimensions we'd have to make sure to parse the visible > > frame, and if it's an inter frame also keep the reference frames around > > to take

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-11-02 Thread Chris Cunningham
> Also, when dealing with a super frame, to get other values like pixel > format and frame dimensions we'd have to make sure to parse the visible > frame, and if it's an inter frame also keep the reference frames around > to take said values from them. Could we avoid the challenges around

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-10-29 Thread James Almer
On 10/29/2018 7:33 PM, Chris Cunningham wrote: > Thanks for pushing the profile part. Turns out I'm also interested in > pixel format, but I follow your comments about dropping the rest of > patch. With the code as-is, how busted are we when parsing a super > frame. Does it correctly grab the

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-10-29 Thread Chris Cunningham
Thanks for pushing the profile part. Turns out I'm also interested in pixel format, but I follow your comments about dropping the rest of patch. With the code as-is, how busted are we when parsing a super frame. Does it correctly grab the profile of the first frame? Chrome actually has a fairly

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-10-25 Thread James Almer
On 10/24/2018 3:12 PM, Chris Cunningham wrote: > On Wed, Oct 3, 2018 at 10:49 AM James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavcodec/vp9_parser.c | 82 - >> 1 file changed, 80 insertions(+), 2 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-10-24 Thread Chris Cunningham
On Wed, Oct 3, 2018 at 10:49 AM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/vp9_parser.c | 82 - > 1 file changed, 80 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c > index

[FFmpeg-devel] [PATCH] avcodec/vp9_parser: export profile and pixel format

2018-10-03 Thread James Almer
Signed-off-by: James Almer --- libavcodec/vp9_parser.c | 82 - 1 file changed, 80 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9_parser.c b/libavcodec/vp9_parser.c index 9531f34a32..d4110f20bf 100644 --- a/libavcodec/vp9_parser.c +++