Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: support multichannel XMA stream configurations

2017-10-06 Thread James Almer
On 10/5/2017 7:29 PM, Banana M. wrote: > Here are samples of many stream configurations, generated with Microsoft's > encoder: > https://mega.nz/#!aQRUnTIT!gWUAfGNLIP62VKV2JEOGoyQ1jbVc3M7_qu7ChXQwb7w > > For real XMA used in games, I've only seen 2ch+..+2ch+1/2ch (usual, what > FFmpeg supported

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: support multichannel XMA stream configurations

2017-10-05 Thread Banana M.
Here are samples of many stream configurations, generated with Microsoft's encoder: https://mega.nz/#!aQRUnTIT!gWUAfGNLIP62VKV2JEOGoyQ1jbVc3M7_qu7ChXQwb7w For real XMA used in games, I've only seen 2ch+..+2ch+1/2ch (usual, what FFmpeg supported before) and 1ch+..+1ch (rare, what motivates this

Re: [FFmpeg-devel] [PATCH] avcodec/wmaprodec: support multichannel XMA stream configurations

2017-10-03 Thread Carl Eugen Hoyos
2017-10-03 23:49 GMT+02:00 : > -if (size < 40 + num_streams * 4) > +if (size != (32 + ((version==3)?0:8) + 4*num_streams)) Could be: (32 + (version == 4) * 8) + 4 * num_streams) Please also provide a sample and a fate test. Thank you, Carl Eugen

[FFmpeg-devel] [PATCH] avcodec/wmaprodec: support multichannel XMA stream configurations

2017-10-03 Thread bananaman255
From: bnnm Signed-off-by: bnnm Now accepts any combination of 1/2ch streams, described in the RIFF chunks/extradata --- libavcodec/wmaprodec.c | 151 - libavformat/wavdec.c | 20 --- 2