Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Tue, Dec 1, 2015 at 7:04 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 57 + > libavfilter/Makefile | 1 + > libavfilter/af_apulsator.c | 279 > + >

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On 12/2/15, Ganesh Ajjanagadde wrote: >> +static void lfo_advance(SimpleLFO *lfo, unsigned count) >> +{ >> +lfo->phase = fabs(lfo->phase + count * lfo->freq / lfo->srate); >> +if (lfo->phase >= 1) >> +lfo->phase = fmod(lfo->phase, 1); >> +} >> + >> +static double

[FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 57 + libavfilter/Makefile | 1 + libavfilter/af_apulsator.c | 279 + libavfilter/allfilters.c | 1 + 4 files changed, 338 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sun, Nov 29, 2015 at 1:21 PM, Nicolas George wrote: > Le nonidi 9 frimaire, an CCXXIV, Clement Boesch a écrit : >> I'd love to have most of the current documentation generated from this doc >> though. The current redundancy is annoying/problematic. > > I second that. We should

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sun, Nov 29, 2015 at 06:39:02PM +0100, Moritz Barsnick wrote: > Hi, > > On Sat, Nov 28, 2015 at 23:26:44 +0100, Paul B Mahol wrote: > > In addition to Ganesh's comments: > > > +@item amount > > +Set modulation. Define how much of original signal is affected by the LFO. > [...] > > +@item

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

Hi, On Sat, Nov 28, 2015 at 23:26:44 +0100, Paul B Mahol wrote: In addition to Ganesh's comments: > +@item amount > +Set modulation. Define how much of original signal is affected by the LFO. [...] > +@item width > +Set pulse width. I would appreciate ranges for both od these. I would guess

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sun, Nov 29, 2015 at 12:45 PM, Clément Bœsch wrote: > On Sun, Nov 29, 2015 at 06:39:02PM +0100, Moritz Barsnick wrote: >> Hi, >> >> On Sat, Nov 28, 2015 at 23:26:44 +0100, Paul B Mahol wrote: >> >> In addition to Ganesh's comments: >> >> > +@item amount >> > +Set modulation.

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

Le nonidi 9 frimaire, an CCXXIV, Clement Boesch a écrit : > I'd love to have most of the current documentation generated from this doc > though. The current redundancy is annoying/problematic. I second that. We should make all the documentation introspectable, and therefore usable by GUI

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

Le nonidi 9 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > I agree with this. There is another comment I would like to make on > this note, related to a patch I have shelved for the moment: > https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/182802.html - > it would be quite annoying to

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On 11/29/15, Ganesh Ajjanagadde wrote: > On Sat, Nov 28, 2015 at 6:21 PM, Ganesh Ajjanagadde > wrote: >> On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >> [...] >> >>> +case

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sun, Nov 29, 2015 at 7:45 AM, Paul B Mahol wrote: > On 11/29/15, Ganesh Ajjanagadde wrote: >> On Sat, Nov 28, 2015 at 6:21 PM, Ganesh Ajjanagadde >> wrote: >>> On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol wrote:

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sun, Nov 29, 2015 at 01:11:07PM -0500, Ganesh Ajjanagadde wrote: > On Sun, Nov 29, 2015 at 12:45 PM, Clément Bœsch wrote: > > On Sun, Nov 29, 2015 at 06:39:02PM +0100, Moritz Barsnick wrote: > >> Hi, > >> > >> On Sat, Nov 28, 2015 at 23:26:44 +0100, Paul B Mahol wrote: > >> > >>

[FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 57 ++ libavfilter/Makefile | 1 + libavfilter/af_apulsator.c | 270 + libavfilter/allfilters.c | 1 + 4 files changed, 329 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol [...] > +case SQUARE: > +val = (phs < 0.5) ? -1 : +1; Something I missed: consider using e.g FFSIGN(phs - 0.5) or FFSIGN(0.5 - phase), can't recall. This is

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 57 ++ > libavfilter/Makefile | 1 + > libavfilter/af_apulsator.c | 270 > + >

Re: [FFmpeg-devel] [PATCH] avfilter: add audio pulsator filter

On Sat, Nov 28, 2015 at 6:21 PM, Ganesh Ajjanagadde wrote: > On Sat, Nov 28, 2015 at 5:26 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol > [...] > >> +case SQUARE: >> +val = (phs < 0.5) ? -1 : +1; > > Something I missed: