Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-08-18 Thread Niki Bowe
On Wed, Mar 4, 2020 at 10:47 AM Carl Eugen Hoyos wrote: > Am Mi., 4. März 2020 um 18:57 Uhr schrieb James Almer : > > > > On 3/4/2020 1:56 PM, Carl Eugen Hoyos wrote: > > > Am Mi., 4. März 2020 um 17:53 Uhr schrieb Sebastian Hubbard > > > : > > >> > > >> I knew this was an ABI change and

Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-03-04 Thread Carl Eugen Hoyos
Am Mi., 4. März 2020 um 18:57 Uhr schrieb James Almer : > > On 3/4/2020 1:56 PM, Carl Eugen Hoyos wrote: > > Am Mi., 4. März 2020 um 17:53 Uhr schrieb Sebastian Hubbard > > : > >> > >> I knew this was an ABI change and probably wasn't going to be > >> acceptable, but I decided to share it for

Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-03-04 Thread James Almer
On 3/4/2020 1:56 PM, Carl Eugen Hoyos wrote: > Am Mi., 4. März 2020 um 17:53 Uhr schrieb Sebastian Hubbard > : >> >> I knew this was an ABI change and probably wasn't going to be >> acceptable, but I decided to share it for consideration anyway. >> There's special code in av_probe_input_format3 to

Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-03-04 Thread Hendrik Leppkes
On Wed, Mar 4, 2020 at 5:57 PM Carl Eugen Hoyos wrote: > > Am Mi., 4. März 2020 um 17:53 Uhr schrieb Sebastian Hubbard > : > > > > I knew this was an ABI change and probably wasn't going to be > > acceptable, but I decided to share it for consideration anyway. > > There's special code in

Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-03-04 Thread Carl Eugen Hoyos
Am Mi., 4. März 2020 um 17:53 Uhr schrieb Sebastian Hubbard : > > I knew this was an ABI change and probably wasn't going to be > acceptable, but I decided to share it for consideration anyway. > There's special code in av_probe_input_format3 to skip over id3 tags > for the purposes of format

Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-03-04 Thread Sebastian Hubbard
I knew this was an ABI change and probably wasn't going to be acceptable, but I decided to share it for consideration anyway. There's special code in av_probe_input_format3 to skip over id3 tags for the purposes of format detection, but Apple uses id3 tags to signal information for HLS audio only

Re: [FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-03-04 Thread Anton Khirnov
Quoting Sebastian Hubbard (2020-02-20 22:43:53) > Added id3v2_buf and id3v2_buf_size fields to AVProbeData. When an id3v2 > tag is found at the start of probed content, id3v2_buf is filled with > a pointer to the start of the tag bytes, and id3v2_buf_size with the > number of bytes in the tag. >

[FFmpeg-devel] [PATCH] avformat/ac3dec: detect fairplay encryption

2020-02-20 Thread Sebastian Hubbard
Added id3v2_buf and id3v2_buf_size fields to AVProbeData. When an id3v2 tag is found at the start of probed content, id3v2_buf is filled with a pointer to the start of the tag bytes, and id3v2_buf_size with the number of bytes in the tag. ac3_eac3_probe checks the tag when present for a private