Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-03 Thread James Almer
On 5/3/2017 3:24 AM, Aaron Levinson wrote: > I don't seem to have the original e-mail in my inbox anymore, so I'll > respond to wm4's response. Overall, the new code is a lot cleaner and > easier to understand than the existing code. > > See below for more. > > Aaron Levinson > > On 5/2/2017

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-03 Thread Aaron Levinson
I don't seem to have the original e-mail in my inbox anymore, so I'll respond to wm4's response. Overall, the new code is a lot cleaner and easier to understand than the existing code. See below for more. Aaron Levinson On 5/2/2017 5:04 PM, wm4 wrote: On Fri, 28 Apr 2017 21:27:56 -0300

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-02 Thread wm4
On Fri, 28 Apr 2017 21:27:56 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/concatdec.c | 94 > - > 1 file changed, 30 insertions(+), 64 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-05-02 Thread James Almer
On 4/28/2017 9:27 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/concatdec.c | 94 > - > 1 file changed, 30 insertions(+), 64 deletions(-) Ping ___

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-04-29 Thread James Almer
On 4/28/2017 9:16 PM, James Almer wrote: > On 4/27/2017 10:59 PM, Michael Niedermayer wrote: >> On Wed, Apr 26, 2017 at 04:40:55PM -0300, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavformat/concatdec.c | 86 >>>

[FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-04-28 Thread James Almer
Signed-off-by: James Almer --- libavformat/concatdec.c | 94 - 1 file changed, 30 insertions(+), 64 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index dd52e4d366..fa9443ff78 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-04-28 Thread James Almer
On 4/27/2017 10:59 PM, Michael Niedermayer wrote: > On Wed, Apr 26, 2017 at 04:40:55PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/concatdec.c | 86 >> +++-- >> 1 file changed, 26 insertions(+), 60

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-04-27 Thread Michael Niedermayer
On Wed, Apr 26, 2017 at 04:40:55PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/concatdec.c | 86 > +++-- > 1 file changed, 26 insertions(+), 60 deletions(-) breaks ./ffmpeg -f concat -i

[FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-04-26 Thread James Almer
Signed-off-by: James Almer --- libavformat/concatdec.c | 86 +++-- 1 file changed, 26 insertions(+), 60 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index dd52e4d366..97ef41e3fc 100644 ---