Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-10-01 Thread James Almer
On 9/26/2018 10:45 AM, Dave Rice wrote: > >> On Sep 12, 2018, at 11:56 AM, Sigríður Regína Sigurþórsdóttir >> wrote: >> >> On Thu, Sep 6, 2018 at 3:31 PM James Almer > > wrote: >>> >>> On 9/6/2018 4:18 PM, James Darnley wrote: On 2018-09-06 19:39, Sigríður Regína

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-26 Thread Dave Rice
> On Sep 12, 2018, at 11:56 AM, Sigríður Regína Sigurþórsdóttir > wrote: > > On Thu, Sep 6, 2018 at 3:31 PM James Almer > wrote: >> >> On 9/6/2018 4:18 PM, James Darnley wrote: >>> On 2018-09-06 19:39, Sigríður Regína Sigurþórsdóttir wrote: +if

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-12 Thread Sigríður Regína Sigurþórsdóttir
On Thu, Sep 6, 2018 at 3:31 PM James Almer wrote: > > On 9/6/2018 4:18 PM, James Darnley wrote: > > On 2018-09-06 19:39, Sigríður Regína Sigurþórsdóttir wrote: > >> +if (s->metadata_header_padding) { > >> +if (s->metadata_header_padding == 1) > >> +

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-06 Thread James Almer
On 9/6/2018 4:18 PM, James Darnley wrote: > On 2018-09-06 19:39, Sigríður Regína Sigurþórsdóttir wrote: >> +if (s->metadata_header_padding) { >> +if (s->metadata_header_padding == 1) >> +s->metadata_header_padding++; >> +put_ebml_void(pb,

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-06 Thread Carl Eugen Hoyos
2018-09-06 21:18 GMT+02:00, James Darnley : > On 2018-09-06 19:39, Sigríður Regína Sigurþórsdóttir wrote: >> +if (s->metadata_header_padding) { >> +if (s->metadata_header_padding == 1) >> +s->metadata_header_padding++; >> +put_ebml_void(pb,

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-06 Thread James Darnley
On 2018-09-06 19:39, Sigríður Regína Sigurþórsdóttir wrote: > +if (s->metadata_header_padding) { > +if (s->metadata_header_padding == 1) > +s->metadata_header_padding++; > +put_ebml_void(pb, s->metadata_header_padding); > +} Unfortunately I was forced to make

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-06 Thread Sigríður Regína Sigurþórsdóttir
On Wed, Sep 5, 2018 at 6:29 PM James Darnley wrote: > > On 2018-09-05 22:52, Sigríður Regína Sigurþórsdóttir wrote: > > +{"reserve_free_space", "Reserve a given amount of space at the > > beginning og the file for unspecified purpose." > > I added the "metadata_header_padding" global option

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-05 Thread James Darnley
On 2018-09-05 22:52, Sigríður Regína Sigurþórsdóttir wrote: > +{"reserve_free_space", "Reserve a given amount of space at the > beginning og the file for unspecified purpose." I added the "metadata_header_padding" global option many years ago. Can you not reuse it for this purpose? Is it

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-05 Thread James Almer
On 9/5/2018 6:36 PM, Carl Eugen Hoyos wrote: > 2018-09-05 22:52 GMT+02:00, Sigríður Regína Sigurþórsdóttir > : >> --- >> Changelog | 1 + >> doc/muxers.texi | 4 >> libavformat/matroskaenc.c | 8 >> 3 files changed, 13 insertions(+) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-05 Thread Carl Eugen Hoyos
2018-09-05 22:52 GMT+02:00, Sigríður Regína Sigurþórsdóttir : > --- > Changelog | 1 + > doc/muxers.texi | 4 > libavformat/matroskaenc.c | 8 > 3 files changed, 13 insertions(+) > > diff --git a/Changelog b/Changelog > index 0975fee..689b04c 100644 > ---

[FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option

2018-09-05 Thread Sigríður Regína Sigurþórsdóttir
--- Changelog | 1 + doc/muxers.texi | 4 libavformat/matroskaenc.c | 8 3 files changed, 13 insertions(+) diff --git a/Changelog b/Changelog index 0975fee..689b04c 100644 --- a/Changelog +++ b/Changelog @@ -21,6 +21,7 @@ version : - Brooktree ProSumer