Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-29 Thread Michael Niedermayer
On Wed, Oct 29, 2014 at 10:27:25AM +0100, tomas.har...@codemill.se wrote: > On 2014-10-28 23:38, Thomas Mundt wrote: > >Carl Eugen, I changed the indentations and attached a unified diff. > >Since I´m on windows I used turtoise git. I hope that´s okay. > > > >Regards, > >Thomas > > Looks good to m

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-29 Thread tomas . hardin
On 2014-10-28 23:38, Thomas Mundt wrote: Carl Eugen, I changed the indentations and attached a unified diff. Since I´m on windows I used turtoise git. I hope that´s okay. Regards, Thomas Looks good to me /Tomas ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-28 Thread Thomas Mundt
Carl Eugen, I changed the indentations and attached a unified diff. Since I´m on windows I used turtoise git. I hope that´s okay. Regards, Thomas avci_mxf.diff Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-28 Thread Thomas Mundt
Okay. I will do so next patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-28 Thread Carl Eugen Hoyos
On Tuesday 28 October 2014 03:36:05 pm Thomas Mundt wrote: > -mxf_write_cdci_common(s, st, mxf_mpegvideo_descriptor_key, 8+5); > -// bit rate > -mxf_write_local_tag(pb, 4, 0x8000); > -avio_wb32(pb, sc->video_bit_rate); > - > -// profile and level > -mxf_write_local_tag(pb, 1

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-28 Thread Thomas Mundt
I´m not happy with the for-loop I coded yesterday night, so I made a new patch. Regards, Thomas --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -42,6 +42,8 @@ #include "libavutil/time_internal.h" #include "libavcodec/bytestream.h" #include "libavcodec/dnxhddata.h" +#include "libavcod

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-27 Thread Thomas Mundt
@ Michael: Sorry, I`m subscribed now. CODEC_ID_H264 changed. @ Kieran: Maybe this would make sense as an option. But in a future step. :-) @ Tomas:Thanks for your suggestions!The component_depth part was taken from Michael´s patch last month. But it also can be changed to 10 bit fixed for AVCI.

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-27 Thread Michael Niedermayer
On Mon, Oct 27, 2014 at 05:21:12PM +, Thomas Mundt wrote: > Hi, I´ve seen that there has been approach last month to implement AVC Intra > mxf muxing. I tested the patches, but it didn´t work with any of my samples. > Since there also has been discussions about the gpl restriction, I rewrote

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-27 Thread Kieran Kunhya
On 27 October 2014 17:21, Thomas Mundt wrote: > Hi, I´ve seen that there has been approach last month to implement AVC Intra > mxf muxing. I tested the patches, but it didn´t work with any of my samples. > Since there also has been discussions about the gpl restriction, I rewrote > the patch. I

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-27 Thread Tomas Härdin
On Mon, 2014-10-27 at 17:21 +, Thomas Mundt wrote: > Hi, I´ve seen that there has been approach last month to implement AVC Intra > mxf muxing. I tested the patches, but it didn´t work with any of my samples. > Since there also has been discussions about the gpl restriction, I rewrote > the

[FFmpeg-devel] [PATCH] avformat/mxfenc: AVC Intra support

2014-10-27 Thread Thomas Mundt
Hi, I´ve seen that there has been approach last month to implement AVC Intra mxf muxing. I tested the patches, but it didn´t work with any of my samples. Since there also has been discussions about the gpl restriction, I rewrote the patch. I had some basics, because I had written a working patch