Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-23 Thread Clément Bœsch
On Sun, Nov 22, 2015 at 04:27:02PM +0100, Michael Niedermayer wrote: [...] > > > IIUC src_x/y are only an approximation, as the exact motion vector > > > isnt an integer in fullpel units so it would be mostly cosmetic > > > if x + 4 >> 8, or /8 is used > > > > yes > > > > mpeg used x >> n, i

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-23 Thread Michael Niedermayer
On Mon, Nov 23, 2015 at 05:07:30PM +0100, Clément Bœsch wrote: > On Mon, Nov 23, 2015 at 03:54:19PM +0100, Michael Niedermayer wrote: > > On Mon, Nov 23, 2015 at 11:01:02AM +0100, Clément Bœsch wrote: > > > On Sun, Nov 22, 2015 at 04:27:02PM +0100, Michael Niedermayer wrote: > > > [...] > > > > >

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-23 Thread Clément Bœsch
On Mon, Nov 23, 2015 at 03:54:19PM +0100, Michael Niedermayer wrote: > On Mon, Nov 23, 2015 at 11:01:02AM +0100, Clément Bœsch wrote: > > On Sun, Nov 22, 2015 at 04:27:02PM +0100, Michael Niedermayer wrote: > > [...] > > > > > IIUC src_x/y are only an approximation, as the exact motion vector > >

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-23 Thread Michael Niedermayer
On Mon, Nov 23, 2015 at 11:01:02AM +0100, Clément Bœsch wrote: > On Sun, Nov 22, 2015 at 04:27:02PM +0100, Michael Niedermayer wrote: > [...] > > > > IIUC src_x/y are only an approximation, as the exact motion vector > > > > isnt an integer in fullpel units so it would be mostly cosmetic > > > >

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-22 Thread Michael Niedermayer
On Sun, Nov 22, 2015 at 11:40:24AM +0100, Clément Bœsch wrote: > On Sun, Nov 22, 2015 at 03:24:55AM +0100, Michael Niedermayer wrote: > [...] > > > diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c > > > index 1b288dd..5eb775a 100644 > > > --- a/libavcodec/snowdec.c > > > +++

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-22 Thread Clément Bœsch
On Sun, Nov 22, 2015 at 03:24:55AM +0100, Michael Niedermayer wrote: [...] > > diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c > > index 1b288dd..5eb775a 100644 > > --- a/libavcodec/snowdec.c > > +++ b/libavcodec/snowdec.c > > @@ -104,8 +104,11 @@ static av_always_inline void > >

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
On Fri, Nov 20, 2015 at 10:36:36AM +0100, Clément Bœsch wrote: > On Fri, Nov 20, 2015 at 10:33:04AM +0100, Clément Bœsch wrote: > [...] > > > i think this doesnt support libavcodec/tpeldsp.c as used in svq3 > > > that would need a motion_xy / 3 > > > > > > i might be missing something but > > >

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
On Fri, Nov 20, 2015 at 10:33:04AM +0100, Clément Bœsch wrote: [...] > > i think this doesnt support libavcodec/tpeldsp.c as used in svq3 > > that would need a motion_xy / 3 > > > > i might be missing something but > > > > * Motion vector > > * src_x = dst_x + motion_x / motion_scale > > *

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
On Mon, Nov 16, 2015 at 02:49:05AM +0100, Michael Niedermayer wrote: > On Thu, Nov 12, 2015 at 03:03:33PM +0100, Clément Bœsch wrote: > > --- > > libavcodec/mpegvideo.c | 36 +--- > > libavcodec/snowdec.c | 4 > > libavfilter/vf_codecview.c | 7

[FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
--- FATE test changes because of the replacement of >>n with /(1<

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-15 Thread Michael Niedermayer
On Thu, Nov 12, 2015 at 03:03:33PM +0100, Clément Bœsch wrote: > --- > libavcodec/mpegvideo.c | 36 +--- > libavcodec/snowdec.c | 4 > libavfilter/vf_codecview.c | 7 +-- > libavutil/motion_vector.h | 8 > libavutil/version.h

[FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-12 Thread Clément Bœsch
--- libavcodec/mpegvideo.c | 36 +--- libavcodec/snowdec.c | 4 libavfilter/vf_codecview.c | 7 +-- libavutil/motion_vector.h | 8 libavutil/version.h| 2 +- 5 files changed, 39 insertions(+), 18 deletions(-) diff --git