Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-09 Thread Michael Niedermayer
On Fri, Oct 09, 2015 at 12:13:05PM +0200, Christophe Gisquet wrote: > 2015-10-09 11:49 GMT+02:00 Michael Niedermayer : > >> Does that actually work even without the patch? I have the same issue > > > > no, it doesnt work before either, its unrelated > > Well I thought it was relevant to the patch

Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-09 Thread Christophe Gisquet
2015-10-09 11:49 GMT+02:00 Michael Niedermayer : >> Does that actually work even without the patch? I have the same issue > > no, it doesnt work before either, its unrelated Well I thought it was relevant to the patch and it was causing that regression. So as far as I know, replacing the previous

Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-09 Thread Michael Niedermayer
On Fri, Oct 09, 2015 at 10:58:50AM +0200, Christophe Gisquet wrote: > Hi, > > 2015-10-09 3:34 GMT+02:00 Michael Niedermayer : > > should i apply this ? > > i cant really say if this is correct or not > > though whie testing i noticed that > > rm ffmpeg ffprobe ; ./configure --progs-suffix=abc &&

Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-09 Thread Christophe Gisquet
Hi, 2015-10-09 3:34 GMT+02:00 Michael Niedermayer : > should i apply this ? > i cant really say if this is correct or not > though whie testing i noticed that > rm ffmpeg ffprobe ; ./configure --progs-suffix=abc && make -j12 fate > ends with > make: *** No rule to make target `ffprobe', needed by

Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-09 Thread Christophe Gisquet
Hi, 2015-10-09 7:59 GMT+02:00 Christophe Gisquet : > But then, why is the stem truncated from dct-test to dct? I have no > idea either. Another rule somewhere? Updating goal targets Considering target file 'libavcodec/dct-test.o'. File 'libavcodec/dct-test.o' does not exist. Looking for an

Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-08 Thread Christophe Gisquet
Hi, 2015-10-09 3:34 GMT+02:00 Michael Niedermayer : > should i apply this ? > i cant really say if this is correct or not > though whie testing i noticed that > rm ffmpeg ffprobe ; ./configure --progs-suffix=abc && make -j12 fate > ends with > make: *** No rule to make target `ffprobe', needed by

Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-08 Thread Michael Niedermayer
On Thu, Oct 08, 2015 at 12:39:09PM +0200, Christophe Gisquet wrote: > Hi, > > I came across a weird bug in dependency generation: basically, the > SUBDIR is sometimes not added. > > That seems easy to fix once the offending line is found, but my > knowledge in Makefile and git blame does not allo

Re: [FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-08 Thread Hendrik Leppkes
On Thu, Oct 8, 2015 at 12:39 PM, Christophe Gisquet wrote: > Hi, > > I came across a weird bug in dependency generation: basically, the > SUBDIR is sometimes not added. > > That seems easy to fix once the offending line is found, but my > knowledge in Makefile and git blame does not allow me to se

[FFmpeg-devel] [PATCH] build system: fix dependency generation

2015-10-08 Thread Christophe Gisquet
Hi, I came across a weird bug in dependency generation: basically, the SUBDIR is sometimes not added. That seems easy to fix once the offending line is found, but my knowledge in Makefile and git blame does not allow me to see if this is correct or there's an historical reason. Only tested msys2