Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Thilo Borgmann
Am 19.07.21 um 22:53 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> --- >> fftools/cmdutils.c | 8 >> libavcodec/x86/aacencdsp_init.c | 2 +- >> libavcodec/x86/aacpsdsp_init.c | 2 +- >> libavcodec/x86/ac3dsp_init.c|

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread James Almer
On 7/19/2021 5:43 PM, Thilo Borgmann wrote: Hi, as requested in review of [1]. Does this require some version bump? Thanks, Thilo [1] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count This is a breaking change. You're removing existing public functions. Wha

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Andreas Rheinhardt
Thilo Borgmann: > --- > fftools/cmdutils.c | 8 > libavcodec/x86/aacencdsp_init.c | 2 +- > libavcodec/x86/aacpsdsp_init.c | 2 +- > libavcodec/x86/ac3dsp_init.c| 4 ++-- > libavcodec/x86/alacdsp_init.c |

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Thilo Borgmann
Am 19.07.21 um 22:48 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> Hi, >> >> as requested in review of [1]. Does this require some version bump? >> > > This has not been requested; quite the opposite: > > Anton Khirnov: >> Sadly we cannot change existing function names. But at least new >> fun

Re: [FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Andreas Rheinhardt
Thilo Borgmann: > Hi, > > as requested in review of [1]. Does this require some version bump? > This has not been requested; quite the opposite: Anton Khirnov: > Sadly we cannot change existing function names. But at least new > functions can use consistent namespacing. You are changing existi

[FFmpeg-devel] [PATCH] lavu/cpu: Use consistent av_cpu_ prefix for all functions

2021-07-19 Thread Thilo Borgmann
Hi, as requested in review of [1]. Does this require some version bump? Thanks, Thilo [1] [PATCH] fftools/cmdutils.c: Add cmd line option to override detection of cpu count From 7b7659db29240b0ee48b469987546a793fcfa3b1 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 19 Jul 2021 22:40: