Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Jonathan Gee
I had noticed fdk is specifically looking for the qscale flag, and otherwise does not do anything with global_quality. I suppose the change is risky for anyone who is setting both global quality and qscale, but with the current code, it seems incorrect to have a conditional based on the scaled

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Timo Rothenpieler
On 22.02.2023 17:46, Gyan Doshi wrote: On 2023-02-22 10:12 pm, Timo Rothenpieler wrote: On 22.02.2023 17:33, Gyan Doshi wrote: From fftools\ffmpeg_mux_init.c 619:    ost->enc_ctx->global_quality = FF_QP2LAMBDA * qscale Regards, Gyan But that's only if you set the old qscale CLI

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Gyan Doshi
On 2023-02-22 10:12 pm, Timo Rothenpieler wrote: On 22.02.2023 17:33, Gyan Doshi wrote: From fftools\ffmpeg_mux_init.c 619:    ost->enc_ctx->global_quality = FF_QP2LAMBDA * qscale Regards, Gyan But that's only if you set the old qscale CLI options. If you set the global_quality option

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Timo Rothenpieler
On 22.02.2023 17:33, Gyan Doshi wrote: From fftools\ffmpeg_mux_init.c 619:    ost->enc_ctx->global_quality = FF_QP2LAMBDA * qscale Regards, Gyan But that's only if you set the old qscale CLI options. If you set the global_quality option directly, there is no factor applied. By dividing

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Gyan Doshi
On 2023-02-22 09:39 pm, Timo Rothenpieler wrote: On 22.02.2023 03:12, JonHGee wrote: libavcodec/libfdk-aacenc: VBR mode currently does not account for scaling when using -aq options with libfdk, resulting in clamping to vbr mode 5 whenever a value >0 is provided.  Adjusting for the scaling

Re: [FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-22 Thread Timo Rothenpieler
On 22.02.2023 03:12, JonHGee wrote: libavcodec/libfdk-aacenc: VBR mode currently does not account for scaling when using -aq options with libfdk, resulting in clamping to vbr mode 5 whenever a value >0 is provided. Adjusting for the scaling factor for proper VBR support. ---

[FFmpeg-devel] [PATCH] libavcodec/libfdk-aacenc: Scale VBR mode with FF_QP2LAMBDA

2023-02-21 Thread JonHGee
libavcodec/libfdk-aacenc: VBR mode currently does not account for scaling when using -aq options with libfdk, resulting in clamping to vbr mode 5 whenever a value >0 is provided. Adjusting for the scaling factor for proper VBR support. --- libavcodec/libfdk-aacenc.c | 2 +- 1 file changed, 1