Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On Wed, Apr 11, 2018 at 12:42:07PM -0700, Richard Shaffer wrote: > On Mon, Apr 9, 2018 at 1:05 AM, Mattias Amnefelt wrote: > > > On 2018-04-05 01:00, Mattias Amnefelt wrote: > > > >> On 2018-04-04 09:22, Mattias Amnefelt wrote: > >> > >>> On 2018-04-04 03:42, James Almer wrote:

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On Mon, Apr 9, 2018 at 1:05 AM, Mattias Amnefelt wrote: > On 2018-04-05 01:00, Mattias Amnefelt wrote: > >> On 2018-04-04 09:22, Mattias Amnefelt wrote: >> >>> On 2018-04-04 03:42, James Almer wrote: >>> On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: > 2018-04-04

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On 2018-04-05 01:00, Mattias Amnefelt wrote: On 2018-04-04 09:22, Mattias Amnefelt wrote: On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: The "-f

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On 2018-04-04 09:22, Mattias Amnefelt wrote: On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: The "-f aac" looks like a bad idea to me. It's also

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: 2018-04-03 7:58 GMT+02:00, Mattias Amnefelt : Yes, my feeling was also that it's

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: > 2018-04-04 3:38 GMT+02:00, James Almer : >> On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: >>> 2018-04-03 7:58 GMT+02:00, Mattias Amnefelt : Yes, my feeling was also that it's better to handle this when

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-04 3:38 GMT+02:00, James Almer : > On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: >> 2018-04-03 7:58 GMT+02:00, Mattias Amnefelt : >>> Yes, my feeling was also that it's better to handle this when possible. >>> >>> You are of course correct that the two

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: > 2018-04-03 7:58 GMT+02:00, Mattias Amnefelt : >> Yes, my feeling was also that it's better to handle this when possible. >> >> You are of course correct that the two tags needs to be inbetween >> frames. Sorry about that, I stripped

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-03 7:58 GMT+02:00, Mattias Amnefelt : > Yes, my feeling was also that it's better to handle this when possible. > > You are of course correct that the two tags needs to be inbetween > frames. Sorry about that, I stripped the sample down too much. I updated > with a sample

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

On Tue, Apr 03, 2018 at 07:58:53AM +0200, Mattias Amnefelt wrote: > Yes, my feeling was also that it's better to handle this when possible. > > You are of course correct that the two tags needs to be inbetween frames. > Sorry about that, I stripped the sample down too much. I updated with a >

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

Yes, my feeling was also that it's better to handle this when possible. You are of course correct that the two tags needs to be inbetween frames. Sorry about that, I stripped the sample down too much. I updated with a sample which has two frames. This new sample fails the test without the

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

It seems like some software can insert an additional ID3v2 tag instead of appending a frame to an existing one. One could argue that that is somewhat broken, but I agree it's better to handle it instead of returning an error. The changes in aacdec.c look ok to me. The fate sample you provided has

[FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

This is a follow-up to https://patchwork.ffmpeg.org/patch/7477/ and changes so all ID3 tags between ADTS frames gets parsed, not just the first one. Sample media for the included fate test is available at http://mattias.amnefe.lt/tmp/id3v2_two_tags.aac From