Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-31 Thread Chris Cunningham
Thanks Michael. Do you mean to also apply the patch to add the test? Maybe you're waiting for further review. On Thu, Jul 28, 2016 at 9:48 AM, Michael Niedermayer wrote: > On Wed, Jul 27, 2016 at 06:35:50PM -0700, Chris Cunningham wrote: > > The file to upload to fate-suite can be found here: >

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-29 Thread Michael Niedermayer
On Fri, Jul 29, 2016 at 12:54:13AM +0200, Michael Niedermayer wrote: > On Wed, Jul 27, 2016 at 06:33:30PM -0700, chcunning...@chromium.org wrote: > > From: Chris Cunningham > > > > Also cleanup parens for the skip_to_timecode check. > > --- > > libavformat/matroskadec.c | 2 +- > > tests/f

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-28 Thread Michael Niedermayer
On Wed, Jul 27, 2016 at 06:33:30PM -0700, chcunning...@chromium.org wrote: > From: Chris Cunningham > > Also cleanup parens for the skip_to_timecode check. > --- > libavformat/matroskadec.c | 2 +- > tests/fate/seek.mak| 3 +++ > tests/ref/seek/mkv-codec-delay | 48 >

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-28 Thread James Almer
On 7/28/2016 5:24 PM, Chris Cunningham wrote: > Thanks Michael. Do you mean to also apply the patch to add the test? Maybe > you're waiting for further review. Usually samples are uploaded some hours or a day before pushing the commit that uses them, to give the FATE clients time to sync. Also, p

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-28 Thread Chris Cunningham
Thanks Michael. Do you mean to also apply the patch to add the test? Maybe you're waiting for further review. On Thu, Jul 28, 2016 at 9:48 AM, Michael Niedermayer wrote: > On Wed, Jul 27, 2016 at 06:35:50PM -0700, Chris Cunningham wrote: > > The file to upload to fate-suite can be found here: >

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-28 Thread Michael Niedermayer
On Wed, Jul 27, 2016 at 06:35:50PM -0700, Chris Cunningham wrote: > The file to upload to fate-suite can be found here: > https://storage.googleapis.com/chcunningham-chrome-shared/codec_delay_opus.mkv uploaded thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-27 Thread Chris Cunningham
The file to upload to fate-suite can be found here: https://storage.googleapis.com/chcunningham-chrome-shared/codec_delay_opus.mkv Alternatively, you can generate it via: ffmpeg -i ../../tests/data/lavf/lavf.mkv -acodec opus -vn codec_delay_opus.mkv On Wed, Jul 27, 2016 at 6:33 PM, wrote: > Fro

[FFmpeg-devel] [PATCH] libavformat/matroskadec: Add test for seeking with codec delay.

2016-07-27 Thread chcunningham
From: Chris Cunningham Also cleanup parens for the skip_to_timecode check. --- libavformat/matroskadec.c | 2 +- tests/fate/seek.mak| 3 +++ tests/ref/seek/mkv-codec-delay | 48 ++ 3 files changed, 52 insertions(+), 1 deletion(-) create