Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

Hi, On Thu, Jul 13, 2023 at 5:13 PM Vignesh Venkat < vigneshv-at-google@ffmpeg.org> wrote: > On Wed, Jun 28, 2023 at 4:27 PM James Almer wrote: > > > > On 6/28/2023 8:25 PM, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Wed, Jun 28, 2023 at 12:48 PM Vignesh Venkat < > > >

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

On Wed, Jun 28, 2023 at 4:27 PM James Almer wrote: > > On 6/28/2023 8:25 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Wed, Jun 28, 2023 at 12:48 PM Vignesh Venkat < > > vigneshv-at-google@ffmpeg.org> wrote: > > > >> i will update the upstream bug to clarify this part. but in the > >>

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

On 6/28/2023 8:25 PM, Ronald S. Bultje wrote: Hi, On Wed, Jun 28, 2023 at 12:48 PM Vignesh Venkat < vigneshv-at-google@ffmpeg.org> wrote: i will update the upstream bug to clarify this part. but in the meantime, i think this patch is reasonable to replicate the behavior of other AV1

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

Hi, On Wed, Jun 28, 2023 at 12:48 PM Vignesh Venkat < vigneshv-at-google@ffmpeg.org> wrote: > i will update the upstream bug to clarify this part. but in the > meantime, i think this patch is reasonable to replicate the behavior > of other AV1 encoders with -g 1. > Sounds reasonable, I

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

On Tue, Jun 27, 2023 at 12:07 PM Ronald S. Bultje wrote: > > Hi Vignesh, > > On Tue, Jun 27, 2023 at 1:55 PM Vignesh Venkat < > vigneshv-at-google@ffmpeg.org> wrote: > > > > >>> In some versions of libsvtav1, setting intra_period_length to 0 > > > [..] > > > > >>> SVT-AV1 Bug:

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

Hi Vignesh, On Tue, Jun 27, 2023 at 1:55 PM Vignesh Venkat < vigneshv-at-google@ffmpeg.org> wrote: > > >>> In some versions of libsvtav1, setting intra_period_length to 0 > [..] > > >>> SVT-AV1 Bug: https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 > > >>> > > >>> Example command:

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

On Mon, Jun 26, 2023 at 4:53 PM James Almer wrote: > > On 6/26/2023 7:32 PM, Vignesh Venkat wrote: > > On Mon, Jun 26, 2023 at 3:17 PM Ronald S. Bultje wrote: > >> > >> Hi, > >> > >> On Mon, Jun 26, 2023 at 1:47 PM Vignesh Venkatasubramanian > >> wrote: > >>> > >>> In some versions of

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

On 6/26/2023 7:32 PM, Vignesh Venkat wrote: On Mon, Jun 26, 2023 at 3:17 PM Ronald S. Bultje wrote: Hi, On Mon, Jun 26, 2023 at 1:47 PM Vignesh Venkatasubramanian wrote: In some versions of libsvtav1, setting intra_period_length to 0 does not produce the intended result (i.e.) all frames

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

On Mon, Jun 26, 2023 at 3:17 PM Ronald S. Bultje wrote: > > Hi, > > On Mon, Jun 26, 2023 at 1:47 PM Vignesh Venkatasubramanian > wrote: >> >> In some versions of libsvtav1, setting intra_period_length to 0 >> does not produce the intended result (i.e.) all frames produced >> are not keyframes.

Re: [FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

Hi, On Mon, Jun 26, 2023 at 1:47 PM Vignesh Venkatasubramanian < vigneshv-at-google@ffmpeg.org> wrote: > In some versions of libsvtav1, setting intra_period_length to 0 > does not produce the intended result (i.e.) all frames produced > are not keyframes. > > Instead handle the gop_size == 1

[FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

In some versions of libsvtav1, setting intra_period_length to 0 does not produce the intended result (i.e.) all frames produced are not keyframes. Instead handle the gop_size == 1 as a special case by setting the pic_type to EB_AV1_KEY_PICTURE when encoding each frame so that all the output