Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 12:01 PM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On 12/13/2015 11:06 AM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Paul B Mahol wrote: On 12/12/15, Mats

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 12:10 PM, Mats Peterson wrote: On 12/13/2015 12:01 PM, Paul B Mahol wrote: Have you provided such several test filest to others? In this directory are three sample Matroska files with QuickTime video that will display with the wrong palette (none at all, really) without the

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Paul B Mahol
On 12/13/15, Mats Peterson wrote: > On 12/13/2015 11:06 AM, Paul B Mahol wrote: >> On 12/13/15, Mats Peterson wrote: >>> On Sat, 12 Dec 2015, Paul B Mahol wrote: >>> On 12/12/15, Mats Peterson

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 11:06 AM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Paul B Mahol wrote: On 12/12/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Michael Niedermayer wrote: On Sat, Dec 12,

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Paul B Mahol
On 12/13/15, Mats Peterson wrote: > On Sat, 12 Dec 2015, Paul B Mahol wrote: > >> On 12/12/15, Mats Peterson wrote: >>> On Sat, 12 Dec 2015, Michael Niedermayer wrote: >>> On Sat, Dec 12, 2015 at 11:17:00AM +, Mats

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-13 Thread Mats Peterson
On 12/13/2015 12:10 PM, Mats Peterson wrote: On 12/13/2015 12:01 PM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On 12/13/2015 11:06 AM, Paul B Mahol wrote: On 12/13/15, Mats Peterson wrote: On Sat, 12 Dec 2015,

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Michael Niedermayer
On Fri, Dec 11, 2015 at 11:32:13AM +, Mats Peterson wrote: > OK, here is an improved version of my previous patch of matroskadec.c that > manages the palette itself without calling code in mov.c. I have borrowed > some code from it, though, and I'm including qtpalette.h. One thing I don't >

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
opment discussions and patches <ffmpeg-devel@ffmpeg.org> Sent: Saturday, December 12, 2015 12:17 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly Obviously that private data is cropped in some way then, since the minimum size of a

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
el@ffmpeg.org> Sent: Saturday, December 12, 2015 12:22 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly 21 is one odd number, to start with. It will make the privata end in the middle of the vendor fourcc, which is often 'appl'. Mats -

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Michael Niedermayer
On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: > Obviously that private data is cropped in some way then, since the minimum > size of a video sample description in QuickTime video is 86 bytes. FFmpeg tries to support all kind of odd and broken files, so even if the file is

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
On Sat, 12 Dec 2015, Paul B Mahol wrote: On 12/12/15, Mats Peterson wrote: On Sat, 12 Dec 2015, Michael Niedermayer wrote: On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: Obviously that private data is cropped in some way then, since the

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Paul B Mahol
On 12/12/15, Mats Peterson wrote: > On Sat, 12 Dec 2015, Michael Niedermayer wrote: > >> On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: >>> Obviously that private data is cropped in some way then, since the >>> minimum size of a video sample

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-12 Thread Mats Peterson
On Sat, 12 Dec 2015, Michael Niedermayer wrote: On Sat, Dec 12, 2015 at 11:17:00AM +, Mats Peterson wrote: Obviously that private data is cropped in some way then, since the minimum size of a video sample description in QuickTime video is 86 bytes. FFmpeg tries to support all kind of

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
2 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly On Friday 11 December 2015 12:32:13 pm Mats Peterson wrote: > OK, here is an improved version of my previous patch of > matroskadec.c that manages the palette itself without calling >

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Carl Eugen Hoyos
On Friday 11 December 2015 12:32:13 pm Mats Peterson wrote: > OK, here is an improved version of my previous patch of > matroskadec.c that manages the palette itself without calling > code in mov.c. I have borrowed some code from it This is completely unacceptable afaict. Unrelated: It is a

[FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
OK, here is an improved version of my previous patch of matroskadec.c that manages the palette itself without calling code in mov.c. I have borrowed some code from it, though, and I'm including qtpalette.h. One thing I don't understand is why the minimum private data size for V_QUICKTIME has

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
Friday, December 11, 2015 12:42 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly On Friday 11 December 2015 12:32:13 pm Mats Peterson wrote: > OK, here is an improved version of my previous patch of > matroskadec.c that manages the

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Moritz Barsnick
On Fri, Dec 11, 2015 at 11:48:15 +, Mats Peterson wrote: > And I said before, I'm not going to "learn" how to use the messy Git > system. What's messy? That's just the way it works here. It may be a bit more tedious for you, but makes life for everyone else (testers, reviewers, committers)

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread compn
On Fri, 11 Dec 2015 12:59:16 + (UTC) Mats Peterson wrote: > I just want someone of you guys to take a look at what I've done. You > know Git much better than me, and you can create a pull request it > looks decent enough. I'm not going to participate a lot

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
for such a long time. Mats  -- Mats Peterson http://matsp888.no-ip.org/~mats/ From: Moritz Barsnick <barsn...@gmx.net> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Sent: Friday, December 11, 2015 1:55 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskad

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
Subject: Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly I just want someone of you guys to take a look at what I've done. You know Git much better than me, and you can create a pull request it looks decent enough. I'm not going to participate a lot in this i

Re: [FFmpeg-devel] [PATCH] matroskadec.c: Handle palettized QuickTime video properly

2015-12-11 Thread Mats Peterson
Reference for additional info. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ From: compn <te...@mi.rr.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Sent: Friday, December 11, 2015 3:08 PM Subject: Re: [FFmpeg-devel] [PATCH] matroskad