Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-06-05 Thread Derek Buitenhuis
On 30/05/2018 00:48, Michael Niedermayer wrote: >> Sorry I missed that! I'd prefer to use your patch over mine. > > iam fine with sasis original patch too Pushed with the changes that were requested in that thread. - Derek ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-29 Thread Michael Niedermayer
On Tue, May 29, 2018 at 07:20:33PM +0100, Derek Buitenhuis wrote: > Hi, > > On Tue, May 29, 2018 at 5:04 PM, Sasi Inguva > wrote: > > Hi. sorry for the late reply. I sent a patch similar to this a while back > > https://patchwork.ffmpeg.org/patch/8227/ but it got lost in the sea. You > > also

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-29 Thread Derek Buitenhuis
Hi, On Tue, May 29, 2018 at 5:04 PM, Sasi Inguva wrote: > Hi. sorry for the late reply. I sent a patch similar to this a while back > https://patchwork.ffmpeg.org/patch/8227/ but it got lost in the sea. You > also want to do, Sorry I missed that! I'd prefer to use your patch over mine. I'll

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-29 Thread Sasi Inguva
Hi. sorry for the late reply. I sent a patch similar to this a while back https://patchwork.ffmpeg.org/patch/8227/ but it got lost in the sea. You also want to do, @@ -3579,7 +3579,8 @@ static void mov_fix_index(MOVContext *mov, AVStream *st)

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-17 Thread Derek Buitenhuis
On Tue, May 15, 2018 at 8:44 PM, Derek Buitenhuis wrote: > We already did this for audio, but it should be done for video too. > If we don't, seeking back to the start of the file, for example, can > become quite broken, since the first N packets will have repeating >

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-15 Thread Tomas Härdin
tis 2018-05-15 klockan 21:21 +0100 skrev Derek Buitenhuis: > On Tue, May 15, 2018 at 9:10 PM, Tomas Härdin > wrote: > > Why don't we do this for every format? > > In this case, it is specific to MOV and MP4, since it's caused by the > way we apply edit lists at the packet

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-15 Thread Derek Buitenhuis
On Tue, May 15, 2018 at 9:10 PM, Tomas Härdin wrote: > Why don't we do this for every format? In this case, it is specific to MOV and MP4, since it's caused by the way we apply edit lists at the packet level (reordering, marking them as discard, changing timestamps, etc.).

Re: [FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-15 Thread Tomas Härdin
tis 2018-05-15 klockan 20:44 +0100 skrev Derek Buitenhuis: > We already did this for audio, but it should be done for video too. > If we don't, seeking back to the start of the file, for example, can > become quite broken, since the first N packets will have repeating > and nonmonotonic PTS, yet

[FFmpeg-devel] [PATCH] mov: Make sure PTS are both monotonically increasing, and unique

2018-05-15 Thread Derek Buitenhuis
We already did this for audio, but it should be done for video too. If we don't, seeking back to the start of the file, for example, can become quite broken, since the first N packets will have repeating and nonmonotonic PTS, yet they need to be decoded even if they are to be discarded.