Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 06:15:30PM +0100, Michael Niedermayer wrote: > On Thu, Feb 26, 2015 at 04:54:02PM +0100, Clément Bœsch wrote: > > On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: > > > On 2/26/2015 1:50 PM, Clément Bœsch wrote: > > > > If the option is set by default, you d

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Michael Niedermayer
On Thu, Feb 26, 2015 at 01:47:01PM +, Derek Buitenhuis wrote: > This also restricts it to MOV and MP4, since it is only > defined for those formats. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/movenc.c | 29 +++-- > 1 file changed, 23 insertions(+), 6 dele

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Michael Niedermayer
On Thu, Feb 26, 2015 at 04:13:10PM +, Derek Buitenhuis wrote: > On 2/26/2015 4:10 PM, Clément Bœsch wrote: > > Yes, it will return an error and abort the operation. Be it done on the > > command line or via the API. So said differently it won't work anymore. > > I do wonder what the point of t

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Michael Niedermayer
On Thu, Feb 26, 2015 at 04:54:02PM +0100, Clément Bœsch wrote: > On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: > > On 2/26/2015 1:50 PM, Clément Bœsch wrote: > > > If the option is set by default, you don't want to warn for no reason. > > > > It's not set by default. That patch

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Derek Buitenhuis
On 2/26/2015 5:02 PM, Michael Niedermayer wrote: > just of the top of my head, i can think of: > AVOptions allows listing the available options, like for automatically > building a list of available options in a GUI > it allows changing the type int->int64, int->double > it stores default value, mi

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Derek Buitenhuis
On 2/26/2015 4:16 PM, Clément Bœsch wrote: >> >> No ABI constraints. >> That's really only better for adding options, which you could do anyway with a struct (add them to the end of the struct, and require use of mystruct_alloc()). - Derek ___ ffmpeg-d

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 05:15:56PM +0100, Clément Bœsch wrote: > On Thu, Feb 26, 2015 at 04:13:10PM +, Derek Buitenhuis wrote: > > On 2/26/2015 4:10 PM, Clément Bœsch wrote: > > > Yes, it will return an error and abort the operation. Be it done on the > > > command line or via the API. So said

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 04:13:10PM +, Derek Buitenhuis wrote: > On 2/26/2015 4:10 PM, Clément Bœsch wrote: > > Yes, it will return an error and abort the operation. Be it done on the > > command line or via the API. So said differently it won't work anymore. > > I do wonder what the point of t

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Derek Buitenhuis
On 2/26/2015 4:10 PM, Clément Bœsch wrote: > Yes, it will return an error and abort the operation. Be it done on the > command line or via the API. So said differently it won't work anymore. I do wonder what the point of the whole AVOption API is then, if we can't break it any more than a struct.

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 05:04:53PM +0100, Hendrik Leppkes wrote: > On Thu, Feb 26, 2015 at 4:54 PM, Clément Bœsch wrote: > > On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: > >> On 2/26/2015 1:50 PM, Clément Bœsch wrote: > >> > If the option is set by default, you don't want to w

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Hendrik Leppkes
On Thu, Feb 26, 2015 at 4:54 PM, Clément Bœsch wrote: > On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: >> On 2/26/2015 1:50 PM, Clément Bœsch wrote: >> > If the option is set by default, you don't want to warn for no reason. >> >> It's not set by default. That patch never went i

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: > On 2/26/2015 1:50 PM, Clément Bœsch wrote: > > If the option is set by default, you don't want to warn for no reason. > > It's not set by default. That patch never went in. > Ah, my bad. > I don't believe silently not writing i

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Derek Buitenhuis
On 2/26/2015 1:50 PM, Clément Bœsch wrote: > If the option is set by default, you don't want to warn for no reason. It's not set by default. That patch never went in. I don't believe silently not writing it is a valid approach. Then again I think setting a default movflag like that instead of cha

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 01:47:01PM +, Derek Buitenhuis wrote: > This also restricts it to MOV and MP4, since it is only > defined for those formats. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/movenc.c | 29 +++-- > 1 file changed, 23 insertions(+), 6 dele

[FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Derek Buitenhuis
This also restricts it to MOV and MP4, since it is only defined for those formats. Signed-off-by: Derek Buitenhuis --- libavformat/movenc.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 210f78e