Re: [FFmpeg-devel] [PATCH] mss2: Fix buffer overflow.

2016-02-26 Thread Reimar Döffinger
On 26.02.2016, at 11:26, wm4 wrote: > On Thu, 25 Feb 2016 22:39:51 +0100 > Reimar Döffinger wrote: > >> On Thu, Feb 25, 2016 at 09:25:08PM +0100, wm4 wrote: >>> On Thu, 25 Feb 2016 21:06:46 +0100 >>> Reimar Döffinger wrote: >>> Reported as https://trac.mplayerhq.hu/ticket/2264 but have >

Re: [FFmpeg-devel] [PATCH] mss2: Fix buffer overflow.

2016-02-26 Thread wm4
On Thu, 25 Feb 2016 22:39:51 +0100 Reimar Döffinger wrote: > On Thu, Feb 25, 2016 at 09:25:08PM +0100, wm4 wrote: > > On Thu, 25 Feb 2016 21:06:46 +0100 > > Reimar Döffinger wrote: > > > > > Reported as https://trac.mplayerhq.hu/ticket/2264 but have > > > not been able to reproduce with FFmpe

Re: [FFmpeg-devel] [PATCH] mss2: Fix buffer overflow.

2016-02-25 Thread Reimar Döffinger
On Thu, Feb 25, 2016 at 09:25:08PM +0100, wm4 wrote: > On Thu, 25 Feb 2016 21:06:46 +0100 > Reimar Döffinger wrote: > > > Reported as https://trac.mplayerhq.hu/ticket/2264 but have > > not been able to reproduce with FFmpeg-only. > > I have no idea what coded_height is used for here exactly, > >

Re: [FFmpeg-devel] [PATCH] mss2: Fix buffer overflow.

2016-02-25 Thread wm4
On Thu, 25 Feb 2016 21:06:46 +0100 Reimar Döffinger wrote: > Reported as https://trac.mplayerhq.hu/ticket/2264 but have > not been able to reproduce with FFmpeg-only. > I have no idea what coded_height is used for here exactly, > so this might not be the best fix. > Fixes the following chain of e

[FFmpeg-devel] [PATCH] mss2: Fix buffer overflow.

2016-02-25 Thread Reimar Döffinger
Reported as https://trac.mplayerhq.hu/ticket/2264 but have not been able to reproduce with FFmpeg-only. I have no idea what coded_height is used for here exactly, so this might not be the best fix. Fixes the following chain of events: ff_mss12_decode_init sets coded_height while not setting height.