From: Thomas Volkert tho...@homer-conferencing.com
Make it more readable and display an error message in case an invalid
header is detected (the current version just returns
AVERROR_INVALIDDATA)
---
libavformat/wavdec.c | 31 ++-
1 file changed, 22 insertions(+), 9
On 12/19/2014 9:09 PM, Thomas Volkert wrote:
+ av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n,
tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24) 0xFF);
I'm sure printing possibly non-printable chars is a great idea. Nothing
could go wrong.
Use 0x%X or something
On Fri, Dec 19, 2014 at 08:15:26PM +, Derek Buitenhuis wrote:
On 12/19/2014 9:09 PM, Thomas Volkert wrote:
+ av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF
header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24)
0xFF);
I'm sure printing possibly
From: Thomas Volkert tho...@homer-conferencing.com
Make it more readable and display an error message in case an invalid
header is detected (the current version just returns
AVERROR_INVALIDDATA)
---
libavformat/wavdec.c | 31 ++-
1 file changed, 22 insertions(+), 9
On 12/19/2014 09:57 PM, Thomas Volkert wrote:
+ av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF, (tag 8)
0xFF, (tag 16) 0xFF, (tag 24) 0xFF);
return AVERROR_INVALIDDATA;
Some remainung tabs - please, remove when commit.
Best regards,
On Fri, Dec 19, 2014 at 09:58:48PM +0100, Thomas Volkert wrote:
On 12/19/2014 09:57 PM, Thomas Volkert wrote:
+av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF
header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24)
0xFF);
return
On 19/12/14 7:00 PM, Michael Niedermayer wrote:
On Fri, Dec 19, 2014 at 09:58:48PM +0100, Thomas Volkert wrote:
On 12/19/2014 09:57 PM, Thomas Volkert wrote:
+ av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF
header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24)
On 12/19/2014 11:03 PM, James Almer wrote:
On 19/12/14 7:00 PM, Michael Niedermayer wrote:
On Fri, Dec 19, 2014 at 09:58:48PM +0100, Thomas Volkert wrote:
On 12/19/2014 09:57 PM, Thomas Volkert wrote:
+ av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF,
