Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-26 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > -s->bpp = av_get_bits_per_pixel(pixdesc) >> 3; > +s->bpp = pixdesc->flags & AV_PIX_FMT_FLAG_PLANAR ? > + 1 : > + av_get_bits_per_pixel(pixdesc) >> 3; This was merged by Michael. Thank you for the reviews, Carl Eugen _

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 11:41:02AM +0100, Carl Eugen Hoyos wrote: > On Monday 23 February 2015 02:02:42 pm Clément Bœsch wrote: > > On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote: > > > On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: > > > > > +int wi

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-24 Thread Carl Eugen Hoyos
On Monday 23 February 2015 02:02:42 pm Clément Bœsch wrote: > On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote: > > On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: > > > +int width = av_pix_fmt_desc_get(frame->format)->flags & > > > AV_PIX_FMT_FLAG_PLAN

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-23 Thread Clément Bœsch
On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote: > On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes a crash with the following command line: > > $ ffmpeg -loop 1 -i fate-suite/lena.pnm -vf format=yuva420p,fade -f null - > >

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-23 Thread Michael Niedermayer
On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a crash with the following command line: > $ ffmpeg -loop 1 -i fate-suite/lena.pnm -vf format=yuva420p,fade -f null - > > Please comment, Carl Eugen > vf_fade.c |5 - > 1 file changed, 4 ins

[FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-22 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a crash with the following command line: $ ffmpeg -loop 1 -i fate-suite/lena.pnm -vf format=yuva420p,fade -f null - Please comment, Carl Eugen diff --git a/libavfilter/vf_fade.c b/libavfilter/vf_fade.c index 80ce75d..5d012af 100644 --- a/libavfilter/vf_fade.c +++ b/libavf