Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-29 Thread Carl Eugen Hoyos
2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos : > We read a display aspect ratio from ARES atom because of several > user-provided samples, I believe it makes sense to also write the > width value into the ares atom depending on the aspect ratio. Patch applied, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-23 Thread Carl Eugen Hoyos
2016-09-23 22:38 GMT+02:00 Paul B Mahol : > On 9/23/16, Paul B Mahol wrote: >> On 9/23/16, Carl Eugen Hoyos wrote: >>> 2016-09-20 19:02 GMT+02:00 Paul B Mahol : >>> How do you have tested that this patch is correct?

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-23 Thread Paul B Mahol
On 9/23/16, Paul B Mahol wrote: > On 9/23/16, Carl Eugen Hoyos wrote: >> 2016-09-20 19:02 GMT+02:00 Paul B Mahol : >> >>> How do you have tested that this patch is correct? >> >> Remuxing the sample from ticket #2125 is broken without this

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-23 Thread Paul B Mahol
On 9/23/16, Carl Eugen Hoyos wrote: > 2016-09-20 19:02 GMT+02:00 Paul B Mahol : > >> How do you have tested that this patch is correct? > > Remuxing the sample from ticket #2125 is broken without this patch. Have you tested with QuickTime player?

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-23 Thread Carl Eugen Hoyos
2016-09-20 19:02 GMT+02:00 Paul B Mahol : > How do you have tested that this patch is correct? Remuxing the sample from ticket #2125 is broken without this patch. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Paul B Mahol
On 9/20/16, Carl Eugen Hoyos wrote: > 2016-09-20 18:47 GMT+02:00 Paul B Mahol : >> On 9/20/16, Carl Eugen Hoyos wrote: >>> 2016-09-20 17:42 GMT+02:00 Paul B Mahol : On 9/20/16, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Carl Eugen Hoyos
2016-09-20 18:47 GMT+02:00 Paul B Mahol : > On 9/20/16, Carl Eugen Hoyos wrote: >> 2016-09-20 17:42 GMT+02:00 Paul B Mahol : >>> On 9/20/16, Carl Eugen Hoyos wrote: 2016-09-20 17:26 GMT+02:00 Paul B Mahol

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Paul B Mahol
On 9/20/16, Carl Eugen Hoyos wrote: > 2016-09-20 17:42 GMT+02:00 Paul B Mahol : >> On 9/20/16, Carl Eugen Hoyos wrote: >>> 2016-09-20 17:26 GMT+02:00 Paul B Mahol : On 9/20/16, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Carl Eugen Hoyos
2016-09-20 17:42 GMT+02:00 Paul B Mahol : > On 9/20/16, Carl Eugen Hoyos wrote: >> 2016-09-20 17:26 GMT+02:00 Paul B Mahol : >>> On 9/20/16, Carl Eugen Hoyos wrote: 2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Paul B Mahol
On 9/20/16, Carl Eugen Hoyos wrote: > 2016-09-20 17:26 GMT+02:00 Paul B Mahol : >> On 9/20/16, Carl Eugen Hoyos wrote: >>> 2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos : Hi! We read a display aspect ratio

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Carl Eugen Hoyos
2016-09-20 17:26 GMT+02:00 Paul B Mahol : > On 9/20/16, Carl Eugen Hoyos wrote: >> 2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos : >>> Hi! >>> >>> We read a display aspect ratio from ARES atom because of several >>> user-provided samples, I

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Paul B Mahol
On 9/20/16, Carl Eugen Hoyos wrote: > 2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos : >> Hi! >> >> We read a display aspect ratio from ARES atom because of several >> user-provided samples, I believe it makes sense to also write the >> width value into the ares

Re: [FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-20 Thread Carl Eugen Hoyos
2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos : > Hi! > > We read a display aspect ratio from ARES atom because of several > user-provided samples, I believe it makes sense to also write the > width value into the ares atom depending on the aspect ratio. Ping. Carl Eugen

[FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

2016-09-19 Thread Carl Eugen Hoyos
Hi! We read a display aspect ratio from ARES atom because of several user-provided samples, I believe it makes sense to also write the width value into the ares atom depending on the aspect ratio. Please review, Carl Eugen From ba2a97d8ff012895e39389dee65c075fe7a20f5c Mon Sep 17 00:00:00 2001