Re: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument

2019-07-02 Thread Michael Niedermayer
On Tue, Jul 02, 2019 at 08:29:34AM +0200, Reimar Döffinger wrote: > On 01.07.2019, at 01:12, Carl Eugen Hoyos wrote: > > Undefined behaviour was reported in ticket #7981, attached patch tries > > to fix it. > > I suspect it makes more sense to check header_len against 0? I suggest to check

Re: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument

2019-07-02 Thread Reimar Döffinger
On 01.07.2019, at 01:12, Carl Eugen Hoyos wrote: > Undefined behaviour was reported in ticket #7981, attached patch tries > to fix it. I suspect it makes more sense to check header_len against 0? And is the NULL pointer really undefined behaviour even if length is 0?

[FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument

2019-06-30 Thread Carl Eugen Hoyos
Hi! Undefined behaviour was reported in ticket #7981, attached patch tries to fix it. Please review, Carl Eugen From d77386d4a18d6d749d15516b5eb6df90507bf1eb Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 1 Jul 2019 01:09:19 +0200 Subject: [PATCH] lavf/nutenc: Do not call memcmp()

Re: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument

2019-06-30 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 01:12 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Undefined behaviour was reported in ticket #7981, attached patch tries Actually #7980. > to fix it. > > Please review, Carl Eugen ___ ffmpeg-devel mailing list