Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-05 Thread Derek Buitenhuis
On 9/5/2023 2:31 PM, James Almer wrote: > Users relying on global side data being in the first packet need to call > the inject() lavf function to enable said functionality. As that > function is now deprecated, they will get the relevant warning and be > directed to the global side data API. >

Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-05 Thread James Almer
On 9/5/2023 10:19 AM, Derek Buitenhuis wrote: On 9/4/2023 5:10 PM, James Almer wrote: * Warn users they need to update their code to not use stream side data (?). Will my code just silently change behavior if it was using stream side data? I legitimately do not know due to the above.

Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-05 Thread Derek Buitenhuis
On 9/4/2023 5:10 PM, James Almer wrote: >> * Warn users they need to update their code to not use stream side data (?). >>Will my code just silently change behavior if it was using stream >>side data? I legitimately do not know due to the above. > > How so? This, like any other deprecated

Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-04 Thread James Almer
On 9/4/2023 12:37 PM, Derek Buitenhuis wrote: On 9/4/2023 4:03 PM, James Almer wrote: 71 files changed, 737 insertions(+), 415 deletions(-) I see no document updates, commit messages, or deprecation warnings that would: * Explain what and why this is happening - this should at the very

Re: [FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-04 Thread Derek Buitenhuis
On 9/4/2023 4:03 PM, James Almer wrote: > 71 files changed, 737 insertions(+), 415 deletions(-) I see no document updates, commit messages, or deprecation warnings that would: * Explain what and why this is happening - this should at the very least be in the commit message(s), if not a doc

[FFmpeg-devel] [PATCH 00/17 v3] AVCodecContext and AVCodecParameters side data

2023-09-04 Thread James Almer
Changes since the previous version: - Reverted the undocumented usage of coded_side_data in decoding scenarios. - Changed the signature of some of the helpers to make them extensible. James Almer (17): avcodec/avcodec: add side data to AVCodecContext avcodec/codec_par: add side data to