Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-27 Thread James Almer
On 1/26/2023 7:49 PM, Jean-Baptiste Kempf wrote: Tbh, I don't see why we should do a 5.2, seeing that 6.0 would be the same features-set with just the ABI change, aka removing deprecated symbols. Also, doing a 5.2 which would not be a LTS, while 5.1 is a LTS is not only very weird, but it

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-26 Thread Jean-Baptiste Kempf
On Fri, 27 Jan 2023, at 00:19, Michael Niedermayer wrote: > On Thu, Jan 26, 2023 at 11:49:14PM +0100, Jean-Baptiste Kempf wrote: >> On Thu, 26 Jan 2023, at 23:16, Michael Niedermayer wrote: >> > I think in general these are the constraints to optimize our release timing >> > against: >> > >> >

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2023 at 11:49:14PM +0100, Jean-Baptiste Kempf wrote: > On Thu, 26 Jan 2023, at 23:16, Michael Niedermayer wrote: > > I think in general these are the constraints to optimize our release timing > > against: > > > > 1. We seem to want 2 releases per year > > Yes. > > > 2. If we do

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-26 Thread Jean-Baptiste Kempf
On Thu, 26 Jan 2023, at 23:16, Michael Niedermayer wrote: > I think in general these are the constraints to optimize our release timing > against: > > 1. We seem to want 2 releases per year Yes. > 2. If we do a major bump, it should ideally happen after a release not > before to give time for

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-26 Thread Michael Niedermayer
On Thu, Jan 26, 2023 at 12:25:39AM +0100, Marton Balint wrote: > > > On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: > > > On Wed, 25 Jan 2023, at 23:28, Marton Balint wrote: > > > On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: > > > > > > > On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote:

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 23:28, Marton Balint wrote: On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 21:08, Marton

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Jean-Baptiste Kempf
On Wed, 25 Jan 2023, at 23:28, Marton Balint wrote: > On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: > >> On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: >>> On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: >>> On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: > On Wed, 25 Jan 2023,

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: On Wed, 25 Jan 2023, James Almer wrote: On 1/24/2023 12:45 PM, Anton Khirnov wrote:

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Paul B Mahol
On 1/25/23, Jean-Baptiste Kempf wrote: > > > On Wed, 25 Jan 2023, at 22:29, Paul B Mahol wrote: >> On 1/25/23, Jean-Baptiste Kempf wrote: >>> >>> >>> On Wed, 25 Jan 2023, at 22:20, Paul B Mahol wrote: On 1/25/23, Jean-Baptiste Kempf wrote: > On Wed, 25 Jan 2023, at 22:03, Marton Balint

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Jean-Baptiste Kempf
On Wed, 25 Jan 2023, at 22:29, Paul B Mahol wrote: > On 1/25/23, Jean-Baptiste Kempf wrote: >> >> >> On Wed, 25 Jan 2023, at 22:20, Paul B Mahol wrote: >>> On 1/25/23, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: > On Wed, 25 Jan 2023, Jean-Baptiste

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Paul B Mahol
On 1/25/23, Jean-Baptiste Kempf wrote: > > > On Wed, 25 Jan 2023, at 22:20, Paul B Mahol wrote: >> On 1/25/23, Jean-Baptiste Kempf wrote: >>> On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: > On Wed, 25 Jan 2023, at 21:08, Marton

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Jean-Baptiste Kempf
On Wed, 25 Jan 2023, at 22:20, Paul B Mahol wrote: > On 1/25/23, Jean-Baptiste Kempf wrote: >> On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: >>> On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: >>> On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: > On Wed, 25 Jan 2023, James

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Paul B Mahol
On 1/25/23, Jean-Baptiste Kempf wrote: > On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: >> On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: >> >>> On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: On Wed, 25 Jan 2023, James Almer wrote: > On 1/24/2023 12:45 PM, Anton Khirnov

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Jean-Baptiste Kempf
On Wed, 25 Jan 2023, at 22:03, Marton Balint wrote: > On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: > >> On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: >>> On Wed, 25 Jan 2023, James Almer wrote: >>> On 1/24/2023 12:45 PM, Anton Khirnov wrote: > So to summarize the discussion so

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, Jean-Baptiste Kempf wrote: On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: On Wed, 25 Jan 2023, James Almer wrote: On 1/24/2023 12:45 PM, Anton Khirnov wrote: So to summarize the discussion so far: * nobody is strongly arguing for an instability period after

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Jean-Baptiste Kempf
On Wed, 25 Jan 2023, at 21:08, Marton Balint wrote: > On Wed, 25 Jan 2023, James Almer wrote: > >> On 1/24/2023 12:45 PM, Anton Khirnov wrote: >>> So to summarize the discussion so far: >>> >>> * nobody is strongly arguing for an instability period after the bump, >>> and there are good

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread Marton Balint
On Wed, 25 Jan 2023, James Almer wrote: On 1/24/2023 12:45 PM, Anton Khirnov wrote: So to summarize the discussion so far: * nobody is strongly arguing for an instability period after the bump, and there are good reasons against it, therefore we should NOT have one * the bump

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-25 Thread James Almer
On 1/24/2023 12:45 PM, Anton Khirnov wrote: So to summarize the discussion so far: * nobody is strongly arguing for an instability period after the bump, and there are good reasons against it, therefore we should NOT have one * the bump can be done either as bump-then-remove or

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-24 Thread Marton Balint
On Tue, 24 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-24 01:06:46) On Tue, 24 Jan 2023, Michael Niedermayer wrote: On Tue, Jan 24, 2023 at 12:22:52AM +0100, Marton Balint wrote: On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-23 23:41:11) On

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-24 Thread Anton Khirnov
So to summarize the discussion so far: * nobody is strongly arguing for an instability period after the bump, and there are good reasons against it, therefore we should NOT have one * the bump can be done either as bump-then-remove or remove-then-bump * there are advantages and

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-24 Thread Anton Khirnov
Quoting Marton Balint (2023-01-24 01:06:46) > On Tue, 24 Jan 2023, Michael Niedermayer wrote: > > On Tue, Jan 24, 2023 at 12:22:52AM +0100, Marton Balint wrote: > >> On Mon, 23 Jan 2023, Anton Khirnov wrote: > >>> Quoting Marton Balint (2023-01-23 23:41:11) > On Mon, 23 Jan 2023, Anton

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Marton Balint
On Tue, 24 Jan 2023, Michael Niedermayer wrote: On Tue, Jan 24, 2023 at 12:22:52AM +0100, Marton Balint wrote: On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-23 23:41:11) On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-21 23:00:52)

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Michael Niedermayer
On Tue, Jan 24, 2023 at 12:22:52AM +0100, Marton Balint wrote: > > > On Mon, 23 Jan 2023, Anton Khirnov wrote: > > > Quoting Marton Balint (2023-01-23 23:41:11) > > > On Mon, 23 Jan 2023, Anton Khirnov wrote: > > > > Quoting Marton Balint (2023-01-21 23:00:52) > > > > >

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Marton Balint
On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-23 23:41:11) On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-21 23:00:52) AVCodecContext->frame_number should be changed to int64_t. I guess you could do something similar which was done for

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Anton Khirnov
Quoting Marton Balint (2023-01-23 23:41:11) > On Mon, 23 Jan 2023, Anton Khirnov wrote: > > Quoting Marton Balint (2023-01-21 23:00:52) > >> AVCodecContext->frame_number should be changed to int64_t. I guess you > >> could do something similar which was done for buffer_size_t, but that > >> seems

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Marton Balint
On Mon, 23 Jan 2023, Anton Khirnov wrote: Quoting Marton Balint (2023-01-21 23:00:52) On Sat, 21 Jan 2023, Michael Niedermayer wrote: On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-01-20 03:05:09) PS: iam not sure i fully understood

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-23 Thread Anton Khirnov
Quoting Marton Balint (2023-01-21 23:00:52) > > > On Sat, 21 Jan 2023, Michael Niedermayer wrote: > > > On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: > >> Quoting Michael Niedermayer (2023-01-20 03:05:09) > >>> PS: iam not sure i fully understood the reason behind why versions

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-22 Thread Michael Niedermayer
On Sat, Jan 21, 2023 at 11:00:52PM +0100, Marton Balint wrote: > > > On Sat, 21 Jan 2023, Michael Niedermayer wrote: > > > On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-01-20 03:05:09) > > > > PS: iam not sure i fully understood the

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Hendrik Leppkes
On Sat, Jan 21, 2023 at 10:30 PM Marvin Scholz wrote: > > Or do you mean that there should be a public devel branch where API/ABI > breaking patches can be proposed for that will eventually be merged into > master at a defined point in time together with major bump? > Yes, I'm talking about one

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marvin Scholz
On 21 Jan 2023, at 22:36, Michael Niedermayer wrote: > On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: >> Quoting Michael Niedermayer (2023-01-20 03:05:09) >>> PS: iam not sure i fully understood the reason behind why versions should be >>> set to "wrong" values during some period,

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marton Balint
On Sat, 21 Jan 2023, Michael Niedermayer wrote: On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: Quoting Michael Niedermayer (2023-01-20 03:05:09) PS: iam not sure i fully understood the reason behind why versions should be set to "wrong" values during some period, so as

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Michael Niedermayer
On Sat, Jan 21, 2023 at 05:51:34PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-01-20 03:05:09) > > PS: iam not sure i fully understood the reason behind why versions should be > > set to "wrong" values during some period, so as always i might be missing > > something > > The

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marvin Scholz
On 21 Jan 2023, at 21:17, Hendrik Leppkes wrote: > On Sat, Jan 21, 2023 at 8:33 PM Marvin Scholz wrote: >>> >>> Alternatively, we could just not have an instability period at all. >>> >> >> Not having any instability period at all seems like a bad idea. >> > > Actually that sounds like the

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Hendrik Leppkes
On Sat, Jan 21, 2023 at 8:33 PM Marvin Scholz wrote: > > > > Alternatively, we could just not have an instability period at all. > > > > Not having any instability period at all seems like a bad idea. > Actually that sounds like the best idea. You would just have to prepare the bump in a branch

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Marvin Scholz
On 21 Jan 2023, at 17:51, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-01-20 03:05:09) >> PS: iam not sure i fully understood the reason behind why versions should be >> set to "wrong" values during some period, so as always i might be missing >> something > > The reason is that

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Anton Khirnov
Quoting Leo Izen (2023-01-20 22:23:23) > On 1/18/23 14:28, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > >> It's been a while since the last bump, so it's time to do some cleaning and > >> remove deprecated APIs. This will also give us an "Open ABI season" in > >> which we

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-21 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-01-20 03:05:09) > PS: iam not sure i fully understood the reason behind why versions should be > set to "wrong" values during some period, so as always i might be missing > something The reason is that after the major bump, the API and ABI are declared to be

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-20 Thread Leo Izen
On 1/18/23 14:28, Anton Khirnov wrote: Quoting James Almer (2023-01-16 14:38:14) It's been a while since the last bump, so it's time to do some cleaning and remove deprecated APIs. This will also give us an "Open ABI season" in which we can do breaking changes (like changing public struct

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-20 Thread Tomas Härdin
ons 2023-01-18 klockan 18:23 -0300 skrev James Almer: > On 1/18/2023 4:28 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > > > It's been a while since the last bump, so it's time to do some > > > cleaning and > > > remove deprecated APIs. This will also give us an "Open ABI

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-19 Thread Michael Niedermayer
On Wed, Jan 18, 2023 at 06:23:43PM -0300, James Almer wrote: > On 1/18/2023 4:28 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > > > It's been a while since the last bump, so it's time to do some cleaning > > > and > > > remove deprecated APIs. This will also give us an

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-19 Thread Anton Khirnov
Quoting James Almer (2023-01-19 13:18:28) > On 1/19/2023 4:26 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-01-18 22:23:43) > >> On 1/18/2023 4:28 PM, Anton Khirnov wrote: > >>> Quoting James Almer (2023-01-16 14:38:14) > It's been a while since the last bump, so it's time to do some

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-19 Thread James Almer
On 1/19/2023 4:26 AM, Anton Khirnov wrote: Quoting James Almer (2023-01-18 22:23:43) On 1/18/2023 4:28 PM, Anton Khirnov wrote: Quoting James Almer (2023-01-16 14:38:14) It's been a while since the last bump, so it's time to do some cleaning and remove deprecated APIs. This will also give us

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-18 Thread Anton Khirnov
Quoting James Almer (2023-01-18 22:23:43) > On 1/18/2023 4:28 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-01-16 14:38:14) > >> It's been a while since the last bump, so it's time to do some cleaning and > >> remove deprecated APIs. This will also give us an "Open ABI season" in > >>

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-18 Thread James Almer
On 1/18/2023 4:28 PM, Anton Khirnov wrote: Quoting James Almer (2023-01-16 14:38:14) It's been a while since the last bump, so it's time to do some cleaning and remove deprecated APIs. This will also give us an "Open ABI season" in which we can do breaking changes (like changing public struct

Re: [FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-18 Thread Anton Khirnov
Quoting James Almer (2023-01-16 14:38:14) > It's been a while since the last bump, so it's time to do some cleaning and > remove deprecated APIs. This will also give us an "Open ABI season" in which > we > can do breaking changes (like changing public struct offsets, public enum > values, adding

[FFmpeg-devel] [PATCH 00/26] Major library version bump

2023-01-16 Thread James Almer
It's been a while since the last bump, so it's time to do some cleaning and remove deprecated APIs. This will also give us an "Open ABI season" in which we can do breaking changes (like changing public struct offsets, public enum values, adding fields to structs that have their size tied to the