Re: [FFmpeg-devel] [PATCH 01/12] fifo: uninline av_fifo_peek2() on the next major bump

2020-02-27 Thread Anton Khirnov
Quoting James Almer (2020-02-25 22:28:57) > On 2/24/2020 9:37 AM, Anton Khirnov wrote: > > This patch will need a following one after the bump to remove dead code, > so IMO might as well just do this in one commit after the bump and save > all the ifdeffery. Sure, that makes sense. -- Anton

Re: [FFmpeg-devel] [PATCH 01/12] fifo: uninline av_fifo_peek2() on the next major bump

2020-02-25 Thread James Almer
On 2/24/2020 9:37 AM, Anton Khirnov wrote: > Inline public functions should be avoided unless absolutely necessary, > and no such necessity exists in this code. > --- > libavutil/fifo.c | 13 + > libavutil/fifo.h | 5 + > 2 files changed, 18 insertions(+) > > diff --git

[FFmpeg-devel] [PATCH 01/12] fifo: uninline av_fifo_peek2() on the next major bump

2020-02-24 Thread Anton Khirnov
Inline public functions should be avoided unless absolutely necessary, and no such necessity exists in this code. --- libavutil/fifo.c | 13 + libavutil/fifo.h | 5 + 2 files changed, 18 insertions(+) diff --git a/libavutil/fifo.c b/libavutil/fifo.c index 1060aedf13..0baaadc521