Re: [FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

Andreas Rheinhardt: > It is perfectly legal for users to use a custom layout > that is equivalent to a supported native one. > In this case the union in AVChannelLayout is not an uint64_t mask, > but a pointer to a custom map. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ac3enc.c | 6

Re: [FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

On 4/7/2024 7:26 PM, Andreas Rheinhardt wrote: James Almer: On 4/7/2024 6:53 PM, Andreas Rheinhardt wrote: James Almer: On 4/7/2024 5:39 PM, Andreas Rheinhardt wrote: It is perfectly legal for users to use a custom layout that is equivalent to a supported native one. Is that really the case

Re: [FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

James Almer: > On 4/7/2024 6:53 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 4/7/2024 5:39 PM, Andreas Rheinhardt wrote: It is perfectly legal for users to use a custom layout that is equivalent to a supported native one. >>> >>> Is that really the case? FFCodec.p.ch_layouts[] has

Re: [FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

On 4/7/2024 6:53 PM, Andreas Rheinhardt wrote: James Almer: On 4/7/2024 5:39 PM, Andreas Rheinhardt wrote: It is perfectly legal for users to use a custom layout that is equivalent to a supported native one. Is that really the case? FFCodec.p.ch_layouts[] has a list of native ones, and the ge

Re: [FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

James Almer: > On 4/7/2024 5:39 PM, Andreas Rheinhardt wrote: >> It is perfectly legal for users to use a custom layout >> that is equivalent to a supported native one. > > Is that really the case? FFCodec.p.ch_layouts[] has a list of native > ones, and the generic encode.c code will reject anythi

Re: [FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

On 4/7/2024 5:39 PM, Andreas Rheinhardt wrote: It is perfectly legal for users to use a custom layout that is equivalent to a supported native one. Is that really the case? FFCodec.p.ch_layouts[] has a list of native ones, and the generic encode.c code will reject anything not in it. I guess

[FFmpeg-devel] [PATCH 01/17] avcodec/ac3enc: Don't presume ch_layout to be AV_CHANNEL_ORDER_NATIVE

It is perfectly legal for users to use a custom layout that is equivalent to a supported native one. In this case the union in AVChannelLayout is not an uint64_t mask, but a pointer to a custom map. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 6 +- 1 file changed, 1 insertion