Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting James Almer (2024-03-05 16:07:05) > > > > One possible solution is to rename the option to something like > > side_data_prefer_external (better names welcome), and have it switch > > between user-supplied (i.e. global or per-packet) and in-bitstream side > > data. > > > > This adds an amb

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread James Almer
On 3/5/2024 11:54 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-05 15:35:02) On 3/5/2024 11:29 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-05 13:30:58) +{"dynamic_hdr10_plus", .default_val.i64 = AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST,

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting James Almer (2024-03-05 15:35:02) > On 3/5/2024 11:29 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-05 13:30:58) > >>> +{"dynamic_hdr10_plus", .default_val.i64 = > >>> AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, > >>> .flags = A|D, .unit =

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread James Almer
On 3/5/2024 11:29 AM, Anton Khirnov wrote: Quoting James Almer (2024-03-05 13:30:58) +{"dynamic_hdr10_plus", .default_val.i64 = AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, .flags = A|D, .unit = "side_data_pkt" }, This one packet/frame level only, not globa

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting James Almer (2024-03-05 13:30:58) > > +{"dynamic_hdr10_plus", .default_val.i64 = > > AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, .flags > > = A|D, .unit = "side_data_pkt" }, > > This one packet/frame level only, not global. It is in sd_global_map >

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread James Almer
On 3/4/2024 10:06 AM, Anton Khirnov wrote: This and the following commits fix #10857 --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 20 libavcodec/decode.c| 36 libavcodec/options_table.h | 13 ++

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-05 Thread Anton Khirnov
Quoting Derek Buitenhuis (2024-03-04 15:05:29) > On 3/4/2024 1:06 PM, Anton Khirnov wrote: > > +/** > > + * Decoding only. May be set by the caller before avcodec_open2() to an > > + * av_malloc()'ed array (or via AVOptions). Owned and freed by the > > decoder > > + * afterwards. >

Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-04 Thread Derek Buitenhuis
On 3/4/2024 1:06 PM, Anton Khirnov wrote: > +/** > + * Decoding only. May be set by the caller before avcodec_open2() to an > + * av_malloc()'ed array (or via AVOptions). Owned and freed by the > decoder > + * afterwards. > + * > + * By default, when some side data type is

[FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference

2024-03-04 Thread Anton Khirnov
This and the following commits fix #10857 --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 20 libavcodec/decode.c| 36 libavcodec/options_table.h | 13 + 4 files changed, 72 insertions(+) diff --gi