Re: [FFmpeg-devel] [PATCH 1/2] h2645_parse: Propagate NAL header parsing errors

2019-03-18 Thread Derek Buitenhuis
On 18/03/2019 20:44, Michael Niedermayer wrote: > do you have a sample for h264 ? (or only teh one for hevc) ? On hand, just HEVC. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] h2645_parse: Propagate NAL header parsing errors

2019-03-18 Thread Michael Niedermayer
On Mon, Mar 18, 2019 at 03:46:09PM +, Derek Buitenhuis wrote: > If we don't propagate these errors, h264dec and hevcdec can get up to all > sorts of > weirdness, especially threaded, while trying to continue on with things they > shouldn't. > Can cause stuff like: do you have a sample for h2

Re: [FFmpeg-devel] [PATCH 1/2] h2645_parse: Propagate NAL header parsing errors

2019-03-18 Thread Derek Buitenhuis
On 18/03/2019 18:38, James Almer wrote: > So, what i'm seeing here is two slice NALs in the same packet (which > means processed in the same decode_nal_units() loop in hevcdec.c) > reporting being the "first slice segment in the pic". And that's > seemingly making the threading logic shit itself.

Re: [FFmpeg-devel] [PATCH 1/2] h2645_parse: Propagate NAL header parsing errors

2019-03-18 Thread James Almer
On 3/18/2019 12:52 PM, Derek Buitenhuis wrote: > On 18/03/2019 15:50, James Almer wrote: >> This will abort the splitting process when it's meant to only discard >> the faulty NAL. Even the log message stats it's skipping it. > > The log message also claims to be AV_LOG_ERROR. > > Also there are

Re: [FFmpeg-devel] [PATCH 1/2] h2645_parse: Propagate NAL header parsing errors

2019-03-18 Thread Derek Buitenhuis
On 18/03/2019 15:50, James Almer wrote: > This will abort the splitting process when it's meant to only discard > the faulty NAL. Even the log message stats it's skipping it. The log message also claims to be AV_LOG_ERROR. Also there are no comments indicating why this is right, or any commit I c

Re: [FFmpeg-devel] [PATCH 1/2] h2645_parse: Propagate NAL header parsing errors

2019-03-18 Thread James Almer
On 3/18/2019 12:46 PM, Derek Buitenhuis wrote: > If we don't propagate these errors, h264dec and hevcdec can get up to all > sorts of > weirdness, especially threaded, while trying to continue on with things they > shouldn't. > Can cause stuff like: > > [hevc @ 0x577107c0] get_buffer() c

[FFmpeg-devel] [PATCH 1/2] h2645_parse: Propagate NAL header parsing errors

2019-03-18 Thread Derek Buitenhuis
If we don't propagate these errors, h264dec and hevcdec can get up to all sorts of weirdness, especially threaded, while trying to continue on with things they shouldn't. Can cause stuff like: [hevc @ 0x577107c0] get_buffer() cannot be called after ff_thread_finish_setup() [hevc @ 0