Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-24 Thread James Almer
On 6/24/2021 10:30 AM, Alan Kelly wrote: Hi, Sorry for the late reply, busy oncall week. Thanks for your responses. I have looked at the code for cpuflags and what you suggested makes sense. I just have a question about naming. EXTERNAL_AVX2_FAST is already used in many places - it checks

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-24 Thread Alan Kelly
Hi, Sorry for the late reply, busy oncall week. Thanks for your responses. I have looked at the code for cpuflags and what you suggested makes sense. I just have a question about naming. EXTERNAL_AVX2_FAST is already used in many places - it checks whether the flag AV_CPU_FLAG_AVXSLOW is set so I

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread James Almer
On 6/14/2021 8:53 AM, Ronald S. Bultje wrote: Hi Alan, On Mon, Jun 14, 2021 at 7:20 AM Alan Kelly < alankelly-at-google@ffmpeg.org> wrote: Broadwell and later have fast gather instructions. --- This is so that the avx2 version of ff_hscale8to15X which uses gather instructions is only

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread Ronald S. Bultje
Hi Alan, On Mon, Jun 14, 2021 at 7:20 AM Alan Kelly < alankelly-at-google@ffmpeg.org> wrote: > Broadwell and later have fast gather instructions. > --- > This is so that the avx2 version of ff_hscale8to15X which uses gather > instructions is only selected on machines where it will actually

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread Andreas Rheinhardt
Alan Kelly: > Broadwell and later have fast gather instructions. > --- > This is so that the avx2 version of ff_hscale8to15X which uses gather > instructions is only selected on machines where it will actually be > faster. > libavutil/cpu.c | 6 ++ > libavutil/cpu.h | 6

[FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread Alan Kelly
Broadwell and later have fast gather instructions. --- This is so that the avx2 version of ff_hscale8to15X which uses gather instructions is only selected on machines where it will actually be faster. libavutil/cpu.c | 6 ++ libavutil/cpu.h | 6 ++