Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Reimar Döffinger
On 11.08.2019, at 21:51, Marton Balint wrote: > > > On Sun, 11 Aug 2019, Reimar Döffinger wrote: > >> On 11.08.2019, at 20:41, Reimar Döffinger wrote: >> >>> On 05.08.2019, at 23:34, Marton Balint wrote: These functions can be used to print a variable number of strings consecutiv

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Marton Balint
On Sun, 11 Aug 2019, Reimar Döffinger wrote: On 11.08.2019, at 20:41, Reimar Döffinger wrote: On 05.08.2019, at 23:34, Marton Balint wrote: These functions can be used to print a variable number of strings consecutively to the IO context. Unlike av_bprintf, no temporery buffer is necessa

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Reimar Döffinger
On 11.08.2019, at 20:41, Reimar Döffinger wrote: > On 05.08.2019, at 23:34, Marton Balint wrote: > >> These functions can be used to print a variable number of strings >> consecutively >> to the IO context. Unlike av_bprintf, no temporery buffer is necessary. > > Hm, is there a use-example pa

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-11 Thread Reimar Döffinger
On 05.08.2019, at 23:34, Marton Balint wrote: > These functions can be used to print a variable number of strings > consecutively > to the IO context. Unlike av_bprintf, no temporery buffer is necessary. Hm, is there a use-example patch I missed? Also is the #define ugliness worth it compared t

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-07 Thread Alexander Strasser
On 2019-08-07 21:28 +0200, Marton Balint wrote: > > On Wed, 7 Aug 2019, Alexander Strasser wrote: > > > Hi Marton! > > > > Not really sure if we need the API, but it definitely looks > > handy. Just not sure how often it will used and really result > > in clearer or shorter code. > > It has better

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-07 Thread Marton Balint
On Wed, 7 Aug 2019, Alexander Strasser wrote: Hi Marton! Not really sure if we need the API, but it definitely looks handy. Just not sure how often it will used and really result in clearer or shorter code. It has better performance than using av_printf because it does not need a temporary

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-06 Thread Marton Balint
On Tue, 6 Aug 2019, Nicolas George wrote: Marton Balint (12019-08-05): These functions can be used to print a variable number of strings consecutively to the IO context. Unlike av_bprintf, no temporery buffer is necessary. I do not like this very much: the VA design disables type checking,

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-06 Thread Alexander Strasser
Hi Marton! Not really sure if we need the API, but it definitely looks handy. Just not sure how often it will used and really result in clearer or shorter code. Not opposed to it though; no strong opinion on this one. Some comments follow inline. No in depth review, just what came to my mind whe

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-06 Thread Nicolas George
Marton Balint (12019-08-05): > These functions can be used to print a variable number of strings > consecutively > to the IO context. Unlike av_bprintf, no temporery buffer is necessary. I do not like this very much: the VA design disables type checking, which makes it rather fragile, and the ben

[FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-05 Thread Marton Balint
These functions can be used to print a variable number of strings consecutively to the IO context. Unlike av_bprintf, no temporery buffer is necessary. Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 16 libavformat/aviobuf.c | 17 +++