Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Thu, Apr 19, 2018 at 09:37:17AM -0700, Jacob Trimble wrote: > On Thu, Apr 19, 2018 at 7:01 AM, James Almer wrote: > > On 4/18/2018 9:42 PM, Michael Niedermayer wrote: > >> On Wed, Apr 18, 2018 at 09:47:17AM -0700, Jacob Trimble wrote: > >>> On Tue, Apr 17, 2018 at 7:11 PM,

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Thu, Apr 19, 2018 at 7:01 AM, James Almer wrote: > On 4/18/2018 9:42 PM, Michael Niedermayer wrote: >> On Wed, Apr 18, 2018 at 09:47:17AM -0700, Jacob Trimble wrote: >>> On Tue, Apr 17, 2018 at 7:11 PM, Michael Niedermayer >>> wrote: On Tue, Apr

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On 4/18/2018 9:42 PM, Michael Niedermayer wrote: > On Wed, Apr 18, 2018 at 09:47:17AM -0700, Jacob Trimble wrote: >> On Tue, Apr 17, 2018 at 7:11 PM, Michael Niedermayer >> wrote: >>> On Tue, Apr 03, 2018 at 04:08:51PM -0700, Jacob Trimble wrote: >> >> Ping again.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Wed, Apr 18, 2018 at 09:47:17AM -0700, Jacob Trimble wrote: > On Tue, Apr 17, 2018 at 7:11 PM, Michael Niedermayer > wrote: > > On Tue, Apr 03, 2018 at 04:08:51PM -0700, Jacob Trimble wrote: > >> >> > >> >> Ping again. I know this is low priority, but I would like to

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Tue, Apr 17, 2018 at 7:11 PM, Michael Niedermayer wrote: > On Tue, Apr 03, 2018 at 04:08:51PM -0700, Jacob Trimble wrote: >> >> >> >> Ping again. I know this is low priority, but I would like to get >> >> these merged soon. >> > >> > Ping. Despite being almost 2

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Tue, Apr 03, 2018 at 04:08:51PM -0700, Jacob Trimble wrote: > >> > >> Ping again. I know this is low priority, but I would like to get > >> these merged soon. > > > > Ping. Despite being almost 2 months old, these patches still apply > > cleanly. Please take a look. These have been in

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

>> >> Ping again. I know this is low priority, but I would like to get >> these merged soon. > > Ping. Despite being almost 2 months old, these patches still apply > cleanly. Please take a look. These have been in review for almost 3 > months. Ping (going to keep pinging this until someone

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Mon, Mar 5, 2018 at 12:22 PM, Jacob Trimble wrote: > On Mon, Feb 12, 2018 at 9:35 AM, Jacob Trimble wrote: >> On Tue, Jan 30, 2018 at 11:27 AM, Jacob Trimble wrote: >>> On Wed, Jan 24, 2018 at 5:46 PM, Michael Niedermayer >>>

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Mon, Feb 12, 2018 at 9:35 AM, Jacob Trimble wrote: > On Tue, Jan 30, 2018 at 11:27 AM, Jacob Trimble wrote: >> On Wed, Jan 24, 2018 at 5:46 PM, Michael Niedermayer >> wrote: >>> On Wed, Jan 24, 2018 at 11:43:26AM -0800, Jacob

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Tue, Jan 30, 2018 at 11:27 AM, Jacob Trimble wrote: > On Wed, Jan 24, 2018 at 5:46 PM, Michael Niedermayer > wrote: >> On Wed, Jan 24, 2018 at 11:43:26AM -0800, Jacob Trimble wrote: >>> On Mon, Jan 22, 2018 at 7:38 PM, Michael Niedermayer >>>

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Wed, Jan 24, 2018 at 5:46 PM, Michael Niedermayer wrote: > On Wed, Jan 24, 2018 at 11:43:26AM -0800, Jacob Trimble wrote: >> On Mon, Jan 22, 2018 at 7:38 PM, Michael Niedermayer >> wrote >> > [...] >> >> This removes support for saio/saiz atoms,

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Wed, Jan 24, 2018 at 11:43:26AM -0800, Jacob Trimble wrote: > On Mon, Jan 22, 2018 at 7:38 PM, Michael Niedermayer > wrote > > [...] > >> This removes support for saio/saiz atoms, but it was incorrect before. > >> A follow-up change will add correct support for those. >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Mon, Jan 22, 2018 at 7:38 PM, Michael Niedermayer wrote > [...] >> This removes support for saio/saiz atoms, but it was incorrect before. >> A follow-up change will add correct support for those. > > This removal should be done by a seperate patch if it is done. > diff

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Wed, Jan 10, 2018 at 05:08:09PM -0800, Jacob Trimble wrote: > On Wed, Jan 10, 2018 at 1:51 PM, Michael Niedermayer > wrote: > > [...] > > > > This causes a crash: > > > > = > > ==4012==ERROR:

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Wed, Jan 10, 2018 at 5:08 PM, Jacob Trimble wrote: > > On Wed, Jan 10, 2018 at 1:51 PM, Michael Niedermayer > wrote: > > [...] > > > > This causes a crash: > > > > = > > ==4012==ERROR:

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Wed, Jan 10, 2018 at 1:51 PM, Michael Niedermayer wrote: > [...] > > This causes a crash: > > = > ==4012==ERROR: AddressSanitizer: heap-buffer-overflow on address > 0x6020eb78 at pc 0x00a944aa bp

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Tue, Jan 09, 2018 at 10:25:12AM -0800, Jacob Trimble wrote: > On Mon, Jan 8, 2018 at 5:19 PM, Carl Eugen Hoyos wrote: > > 2018-01-08 23:16 GMT+01:00 Jacob Trimble > > : > >>> You can't remove API just like that without a deprecation

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Mon, Jan 8, 2018 at 5:19 PM, Carl Eugen Hoyos wrote: > 2018-01-08 23:16 GMT+01:00 Jacob Trimble : >>> You can't remove API just like that without a deprecation period. >>> Add a new av_aes_ctr_set_full_iv() function, and either leave >>>

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-01-08 23:16 GMT+01:00 Jacob Trimble : >> You can't remove API just like that without a deprecation period. >> Add a new av_aes_ctr_set_full_iv() function, and either leave >> av_aes_ctr_set_iv() alone or deprecate it if it effectively becomes >> superfluous

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

> You can't remove API just like that without a deprecation period. > Add a new av_aes_ctr_set_full_iv() function, and either leave > av_aes_ctr_set_iv() alone or deprecate it if it effectively becomes > superfluous after adding the new function. > > Also, this patch needs to be split in three.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-01-05 20:49 GMT+01:00 Jacob Trimble : > +if (!frag_stream_info->encryption_index) { > +frag_stream_info->encryption_index = > av_mallocz(sizeof(MOVEncryptionIndex)); sizeof(variable), please. [...] > +sample_count =

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On 1/5/2018 4:49 PM, Jacob Trimble wrote: > diff --git a/libavutil/aes_ctr.c b/libavutil/aes_ctr.c > index e9c568fe0d..6ed69c8e10 100644 > --- a/libavutil/aes_ctr.c > +++ b/libavutil/aes_ctr.c > @@ -38,10 +38,9 @@ struct AVAESCTR *av_aes_ctr_alloc(void) > return av_mallocz(sizeof(struct

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

On Fri, Jan 5, 2018 at 11:49 AM, Jacob Trimble wrote: >> [...] This adds two new fate tests that need to be uploaded by someone: https://storage.googleapis.com/shaka-demo-assets/_bugs/ffmpeg-fate-files/mov-frag-encrypted.mp4

[FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

- Parse schm atom to get different encryption schemes. - Allow senc atom to appear in track fragments. - Allow 16-byte IVs. - Allow constant IVs (specified in tenc). - Allow only tenc to specify encryption (i.e. no senc/saiz/saio). - Use sample descriptor to detect clear fragments. This doesn't