Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-05 Thread Anton Khirnov
Quoting Stefano Sabatini (2023-06-05 10:08:07) > Il dom 4 giu 2023, 16:34 Marvin Scholz ha scritto: > > > On 4 Jun 2023, at 16:25, Stefano Sabatini wrote: > > [...] > > > About your patch, please mention that the pop operation is > > > destructive. We probably want to make that behavior

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-05 Thread Anton Khirnov
Quoting Marvin Scholz (2023-05-01 13:44:54) > diff --git a/libavutil/dict.h b/libavutil/dict.h > index 713c9e361a..b2ab55a026 100644 > --- a/libavutil/dict.h > +++ b/libavutil/dict.h > @@ -172,6 +172,26 @@ int av_dict_set(AVDictionary **pm, const char *key, > const char *value, int flags > */ >

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-05 Thread Stefano Sabatini
Il dom 4 giu 2023, 16:34 Marvin Scholz ha scritto: > On 4 Jun 2023, at 16:25, Stefano Sabatini wrote: > [...] > > About your patch, please mention that the pop operation is > > destructive. We probably want to make that behavior configurable > > through flags, but I'm fine to keep the current

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-04 Thread Marvin Scholz
On 4 Jun 2023, at 16:25, Stefano Sabatini wrote: > On date Friday 2023-05-26 11:11:48 +0200, Marvin Scholz wrote: >> On 26 May 2023, at 8:05, Stefano Sabatini wrote: >> >>> On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: On 22 May 2023, at 1:52, Stefano Sabatini wrote: >

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-06-04 Thread Stefano Sabatini
On date Friday 2023-05-26 11:11:48 +0200, Marvin Scholz wrote: > On 26 May 2023, at 8:05, Stefano Sabatini wrote: > > > On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: > >> On 22 May 2023, at 1:52, Stefano Sabatini wrote: [...] > > Should we also support the case with multiple

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-26 Thread Marvin Scholz
On 26 May 2023, at 22:02, Michael Niedermayer wrote: > On Fri, May 26, 2023 at 11:11:48AM +0200, Marvin Scholz wrote: >> >> >> On 26 May 2023, at 8:05, Stefano Sabatini wrote: >> >>> On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: On 22 May 2023, at 1:52, Stefano Sabatini

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-26 Thread James Almer
On 5/26/2023 6:11 AM, Marvin Scholz wrote: On 26 May 2023, at 8:05, Stefano Sabatini wrote: On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: On 22 May 2023, at 1:52, Stefano Sabatini wrote: On date Monday 2023-05-01 13:44:54 +0200, Marvin Scholz wrote: This new API allows

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-26 Thread Michael Niedermayer
On Fri, May 26, 2023 at 11:11:48AM +0200, Marvin Scholz wrote: > > > On 26 May 2023, at 8:05, Stefano Sabatini wrote: > > > On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: > >> On 22 May 2023, at 1:52, Stefano Sabatini wrote: > >> > >>> On date Monday 2023-05-01 13:44:54 +0200,

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-26 Thread Marvin Scholz
On 26 May 2023, at 8:05, Stefano Sabatini wrote: > On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: >> On 22 May 2023, at 1:52, Stefano Sabatini wrote: >> >>> On date Monday 2023-05-01 13:44:54 +0200, Marvin Scholz wrote: This new API allows to remove an entry and obtain

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-26 Thread Stefano Sabatini
On date Monday 2023-05-22 11:23:24 +0200, Marvin Scholz wrote: > On 22 May 2023, at 1:52, Stefano Sabatini wrote: > > > On date Monday 2023-05-01 13:44:54 +0200, Marvin Scholz wrote: > >> This new API allows to remove an entry and obtain ownership of the > >> key/value that was associated with

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-22 Thread Marvin Scholz
On 22 May 2023, at 1:52, Stefano Sabatini wrote: > On date Monday 2023-05-01 13:44:54 +0200, Marvin Scholz wrote: >> This new API allows to remove an entry and obtain ownership of the >> key/value that was associated with the removed entry. Thanks for the review! >> --- >> doc/APIchanges

Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-21 Thread Stefano Sabatini
On date Monday 2023-05-01 13:44:54 +0200, Marvin Scholz wrote: > This new API allows to remove an entry and obtain ownership of the > key/value that was associated with the removed entry. > --- > doc/APIchanges | 4 > libavutil/dict.c | 27 +++ >

[FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop

2023-05-01 Thread Marvin Scholz
This new API allows to remove an entry and obtain ownership of the key/value that was associated with the removed entry. --- doc/APIchanges | 4 libavutil/dict.c | 27 +++ libavutil/dict.h | 20 libavutil/tests/dict.c | 34