Re: [FFmpeg-devel] [PATCH 1/4] x86: xvid: port SSE2 idct to yasm

2015-03-12 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 08:09:35PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-03-11 3:46 GMT+01:00 James Almer : > > Should be YASM-OBJS, and moved to the end of the file. > > Also, related to the build failure Michael mentioned for the second patch, > > this is > > missing an inline -> exte

Re: [FFmpeg-devel] [PATCH 1/4] x86: xvid: port SSE2 idct to yasm

2015-03-12 Thread Christophe Gisquet
Hi, 2015-03-11 3:46 GMT+01:00 James Almer : > Should be YASM-OBJS, and moved to the end of the file. > Also, related to the build failure Michael mentioned for the second patch, > this is > missing an inline -> external change in libavcodec/x86/dct-test.c Here you are. Passes fate-xvid-idct and

Re: [FFmpeg-devel] [PATCH 1/4] x86: xvid: port SSE2 idct to yasm

2015-03-10 Thread James Almer
On 10/03/15 8:11 PM, Christophe Gisquet wrote: > The main difference consists in renaming properly labels, and > letting yasm select the gprs for skipping 1D transforms. > --- > libavcodec/x86/Makefile| 2 +- > libavcodec/x86/xvididct.asm| 379 ++ >

[FFmpeg-devel] [PATCH 1/4] x86: xvid: port SSE2 idct to yasm

2015-03-10 Thread Christophe Gisquet
The main difference consists in renaming properly labels, and letting yasm select the gprs for skipping 1D transforms. --- libavcodec/x86/Makefile| 2 +- libavcodec/x86/xvididct.asm| 379 ++ libavcodec/x86/xvididct_init.c | 18 +- libavcodec/x86/x