Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-05 Thread Ganesh Ajjanagadde
On Sat, Dec 5, 2015 at 1:20 AM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> On Fri, Dec 4, 2015 at 3:49 PM, Paul B Mahol wrote: >>> On 12/4/15, Ganesh Ajjanagadde wrote: On Fri, Dec 4, 2015 at 11:36

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-05 Thread Clément Bœsch
On Sat, Dec 05, 2015 at 06:20:29AM +, Paul B Mahol wrote: [...] > Yes, it was and still is wasted time, to find out that there is no > leaking at all. There is an allocation, so it could fail under certain context/system conditions. There is also branching in that code assuming it could fail,

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Paul B Mahol
On 12/4/15, Ganesh Ajjanagadde wrote: > On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: >> On 12/2/15, Paul B Mahol wrote: >>> On 12/2/15, Ganesh Ajjanagadde wrote: On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Ganesh Ajjanagadde
On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: > On 12/2/15, Paul B Mahol wrote: >> On 12/2/15, Ganesh Ajjanagadde wrote: >>> On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: On 12/1/15, Nicolas George

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 3:49 PM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: >>> On 12/4/15, Ganesh Ajjanagadde wrote: On Wed, Dec 2, 2015 at 1:42

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Paul B Mahol
On 12/4/15, Ganesh Ajjanagadde wrote: > On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: >> On 12/4/15, Ganesh Ajjanagadde wrote: >>> On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: On 12/2/15, Paul B Mahol

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Paul B Mahol
On 12/4/15, Ganesh Ajjanagadde wrote: > On Fri, Dec 4, 2015 at 3:49 PM, Paul B Mahol wrote: >> On 12/4/15, Ganesh Ajjanagadde wrote: >>> On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: On 12/4/15, Ganesh

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-04 Thread Ganesh Ajjanagadde
On Fri, Dec 4, 2015 at 11:36 AM, Paul B Mahol wrote: > On 12/4/15, Ganesh Ajjanagadde wrote: >> On Wed, Dec 2, 2015 at 1:42 AM, Paul B Mahol wrote: >>> On 12/2/15, Paul B Mahol wrote: On 12/2/15, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Ganesh Ajjanagadde
On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: > On 12/1/15, Nicolas George wrote: >> Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a ecrit : >>> Similar how its freed when no longer used. >> >> Please elaborate. I know the API, I do not see what you

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Paul B Mahol
On 12/2/15, Ganesh Ajjanagadde wrote: > On Tue, Dec 1, 2015 at 2:14 PM, Paul B Mahol wrote: >> On 12/1/15, Nicolas George wrote: >>> Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a ecrit : Similar how its freed when no longer used. >>>

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Paul B Mahol
On 12/1/15, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a ecrit : >> Similar how its freed when no longer used. > > Please elaborate. I know the API, I do not see what you suggest. > > (Thanks for trimming.) > > Regards, After carefully looking at

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Nicolas George
Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a écrit : > Similar how its freed when no longer used. Please elaborate. I know the API, I do not see what you suggest. (Thanks for trimming.) Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Paul B Mahol
Dana 1. 12. 2015. 15:08 osoba "Nicolas George" napisala je: > > Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a écrit : > > I don't think API is needed for this. Just one call in right place IIRC. > > Can you show an example? That would be more useful than handwaving. I must >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Ganesh Ajjanagadde
On Tue, Dec 1, 2015 at 3:50 AM, Paul B Mahol wrote: > On 12/1/15, Ganesh Ajjanagadde wrote: >> On Sun, Nov 29, 2015 at 6:03 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> doc/filters.texi |

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Paul B Mahol
On 12/1/15, Ganesh Ajjanagadde wrote: > On Tue, Dec 1, 2015 at 3:50 AM, Paul B Mahol wrote: >> On 12/1/15, Ganesh Ajjanagadde wrote: >>> On Sun, Nov 29, 2015 at 6:03 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-01 Thread Nicolas George
Le primidi 11 frimaire, an CCXXIV, Paul B Mahol a écrit : > I don't think API is needed for this. Just one call in right place IIRC. Can you show an example? That would be more useful than handwaving. I must say I have no idea what the "right place" would be. Also, I would appreciate if Ganesh

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-11-30 Thread Ganesh Ajjanagadde
On Sun, Nov 29, 2015 at 6:03 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 61 + > libavfilter/Makefile | 1 + > libavfilter/af_agate.c | 170 >

[FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-11-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 61 + libavfilter/Makefile | 1 + libavfilter/af_agate.c | 170 ++- libavfilter/allfilters.c | 1 + 4 files changed, 230 insertions(+), 3