On 1/6/2017 8:33 PM, Soft Works wrote:
> Revision #4: Don't create CRC32 for preliminary headers
>
> The following three commits created a regression by writing initially
> invalid mkv headers:
>
> 650e17d88b63b5aca6e0a43483e89e64b0f7d2dd avformat/matroskaenc: write a
> CRC32 element on Tags
> 3b
Revision #4: Don't create CRC32 for preliminary headers
The following three commits created a regression by writing initially
invalid mkv headers:
650e17d88b63b5aca6e0a43483e89e64b0f7d2dd avformat/matroskaenc: write a
CRC32 element on Tags
3bcadf822711720ff0f8d14db71ae47cdf97e652 avformat/matrosk
> James Almer wrote
>
>
> start_ebml_master_crc32() only reserves the space needed for the CRC32
> element,
> which is then written by end_ebml_master_crc32(). The preliminary header will
> have a couple six bytes long Void elements that every parser will promptly
> ignore.
>
> CRC32 elements o
On 1/6/2017 2:41 PM, Soft Works wrote:
>> From: ffmpeg-devel on behalf of James
>> Almer
>> Sent: Friday, January 6, 2017 6:02 AM
>>
>> IMO, no point calculating and writing a CRC element for this temporary state.
>> You can rename and simplify this function into something like
>>
>> static void
> From: ffmpeg-devel on behalf of James Almer
>
> Sent: Friday, January 6, 2017 6:02 AM
>
> IMO, no point calculating and writing a CRC element for this temporary state.
> You can rename and simplify this function into something like
>
> static void end_ebml_master_preliminary(AVIOContext *pb,
On 1/5/2017 3:07 PM, Soft Works wrote:
> The following three commits created a regression by writing initially
> invalid mkv headers:
>
> 650e17d88b63b5aca6e0a43483e89e64b0f7d2dd avformat/matroskaenc: write a
> CRC32 element on Tags
> 3bcadf822711720ff0f8d14db71ae47cdf97e652 avformat/matroskaenc:
The following three commits created a regression by writing initially
invalid mkv headers:
650e17d88b63b5aca6e0a43483e89e64b0f7d2dd avformat/matroskaenc: write a
CRC32 element on Tags
3bcadf822711720ff0f8d14db71ae47cdf97e652 avformat/matroskaenc: write a
CRC32 element on Info
ee888cfbe777cd2916a35
