Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

James Almer (2018-08-24): > Invalid input (say, a packet reporting a frame size of the equivalent of > 1ms) would assert before and after this patch. Do you consider an assert > that triggers on invalid input to be wrong? I thought that was the > entire point of one... Assert failures cause an

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

On 8/24/2018 12:56 PM, Carl Eugen Hoyos wrote: > 2018-08-24 17:53 GMT+02:00, James Almer : >> On 8/24/2018 12:47 PM, Carl Eugen Hoyos wrote: >>> 2018-08-24 17:41 GMT+02:00, James Almer : On 8/24/2018 12:33 PM, Carl Eugen Hoyos wrote: > 2018-08-24 17:31 GMT+02:00, James Almer : >> On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

On Fri, Aug 24, 2018 at 5:53 PM James Almer wrote: > > On 8/24/2018 12:47 PM, Carl Eugen Hoyos wrote: > > 2018-08-24 17:41 GMT+02:00, James Almer : > >> On 8/24/2018 12:33 PM, Carl Eugen Hoyos wrote: > >>> 2018-08-24 17:31 GMT+02:00, James Almer : > On 8/24/2018 7:19 AM, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

2018-08-24 17:53 GMT+02:00, James Almer : > On 8/24/2018 12:47 PM, Carl Eugen Hoyos wrote: >> 2018-08-24 17:41 GMT+02:00, James Almer : >>> On 8/24/2018 12:33 PM, Carl Eugen Hoyos wrote: 2018-08-24 17:31 GMT+02:00, James Almer : > On 8/24/2018 7:19 AM, Carl Eugen Hoyos wrote: >>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

On 8/24/2018 12:47 PM, Carl Eugen Hoyos wrote: > 2018-08-24 17:41 GMT+02:00, James Almer : >> On 8/24/2018 12:33 PM, Carl Eugen Hoyos wrote: >>> 2018-08-24 17:31 GMT+02:00, James Almer : On 8/24/2018 7:19 AM, Carl Eugen Hoyos wrote: > 2018-08-24 0:17 GMT+02:00, James Almer : >> Fixes

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

2018-08-24 17:41 GMT+02:00, James Almer : > On 8/24/2018 12:33 PM, Carl Eugen Hoyos wrote: >> 2018-08-24 17:31 GMT+02:00, James Almer : >>> On 8/24/2018 7:19 AM, Carl Eugen Hoyos wrote: 2018-08-24 0:17 GMT+02:00, James Almer : > Fixes assertion failures when trying to mux such streams.

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

On 8/24/2018 12:33 PM, Carl Eugen Hoyos wrote: > 2018-08-24 17:31 GMT+02:00, James Almer : >> On 8/24/2018 7:19 AM, Carl Eugen Hoyos wrote: >>> 2018-08-24 0:17 GMT+02:00, James Almer : Fixes assertion failures when trying to mux such streams. >>> >>> Shouldn't this be 1/2? >>> >>> And does

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

2018-08-24 17:31 GMT+02:00, James Almer : > On 8/24/2018 7:19 AM, Carl Eugen Hoyos wrote: >> 2018-08-24 0:17 GMT+02:00, James Almer : >>> Fixes assertion failures when trying to mux such streams. >> >> Shouldn't this be 1/2? >> >> And does this assert now for libavformat users that use >> new

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

On 8/24/2018 7:19 AM, Carl Eugen Hoyos wrote: > 2018-08-24 0:17 GMT+02:00, James Almer : >> Fixes assertion failures when trying to mux such streams. > > Shouldn't this be 1/2? > > And does this assert now for libavformat users that use > new libopus (but not libavcodec) or do I misunderstand?

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

2018-08-24 0:17 GMT+02:00, James Almer : > Fixes assertion failures when trying to mux such streams. Shouldn't this be 1/2? And does this assert now for libavformat users that use new libopus (but not libavcodec) or do I misunderstand? Carl Eugen ___

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

Fixes assertion failures when trying to mux such streams. Signed-off-by: James Almer --- libavformat/movenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8ad7026741..1b1d765f7d 100644 --- a/libavformat/movenc.c +++