Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread flow gg
Thank you, I learned this and updated it in this reply. James Almer 于2023年12月30日周六 22:46写道: > On 12/30/2023 10:59 AM, flow gg wrote: > > Okay, it has been modified in this reply. > > > From d62f363e3aad534c7ead5f3015029b3e7cbbff46 Mon Sep 17 00:00:00 2001 > > From: sunyuechi > > Date: Fri, 29

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread James Almer
On 12/30/2023 10:59 AM, flow gg wrote: Okay, it has been modified in this reply. From d62f363e3aad534c7ead5f3015029b3e7cbbff46 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 29 Dec 2023 13:09:21 +0800 Subject: [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test ---

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread flow gg
Okay, it has been modified in this reply. Martin Storsjö 于2023年12月29日周五 22:35写道: > On Fri, 29 Dec 2023, James Almer wrote: > > > On 12/29/2023 9:16 AM, Martin Storsjö wrote: > >> On Fri, 29 Dec 2023, flow gg wrote: > >> > >>> Tests on x86 might fail, possibly due to a 16-bit sub overflow > >> >

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread Rémi Denis-Courmont
Le 29 décembre 2023 12:57:01 GMT+01:00, flow gg a écrit : >Tests on x86 might fail, possibly due to a 16-bit sub overflow I don't know anything about the SVQ encoder. Still, especially for an encoder, overflows are probably not expected. So then it is as Martin wrote.

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread Martin Storsjö
On Fri, 29 Dec 2023, James Almer wrote: On 12/29/2023 9:16 AM, Martin Storsjö wrote: On Fri, 29 Dec 2023, flow gg wrote: Tests on x86 might fail, possibly due to a 16-bit sub overflow If this only happens in checkasm but not in real life use, it means that the checkasm test input is out

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread James Almer
On 12/29/2023 9:16 AM, Martin Storsjö wrote: On Fri, 29 Dec 2023, flow gg wrote: Tests on x86 might fail, possibly due to a 16-bit sub overflow If this only happens in checkasm but not in real life use, it means that the checkasm test input is out of range, and we should try to mimic the

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread Martin Storsjö
On Fri, 29 Dec 2023, flow gg wrote: Tests on x86 might fail, possibly due to a 16-bit sub overflow If this only happens in checkasm but not in real life use, it means that the checkasm test input is out of range, and we should try to mimic the real input data. If the issue is off-by-one

[FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-29 Thread flow gg
Tests on x86 might fail, possibly due to a 16-bit sub overflow From 8bde7750ec7adc2437843e14d4be85fb900d1b16 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 29 Dec 2023 13:09:21 +0800 Subject: [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test --- tests/checkasm/Makefile | 1 +