Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, Stefano Sabatini a écrit : > I'd like to fix the libavformat API/ffprobe, so I'm in favor of this > patchset. > > Regarding the specific patch, we could keep the REDO error code (and > mark in the comment that's intended for internal use), or add and use > an

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-12-03 Thread Stefano Sabatini
On date Friday 2015-11-27 15:27:02 +0100, Clément Bœsch encoded: > On Fri, Nov 27, 2015 at 01:10:29PM +0100, Nicolas George wrote: > > Le septidi 7 frimaire, an CCXXIV, Clement Boesch a écrit : > > > But then it's still exposed by the API, and someone looking at handling > > > every error code

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-27 Thread Nicolas George
Le septidi 7 frimaire, an CCXXIV, Clement Boesch a écrit : > But then it's still exposed by the API, and someone looking at handling > every error code might be wondering how to handle it. « Handling every error code » seems to me like an impossible and idiotic objective. What do you suggest,

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-27 Thread Clément Bœsch
On Fri, Nov 27, 2015 at 01:10:29PM +0100, Nicolas George wrote: > Le septidi 7 frimaire, an CCXXIV, Clement Boesch a écrit : > > But then it's still exposed by the API, and someone looking at handling > > every error code might be wondering how to handle it. > > « Handling every error code »

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-27 Thread Clément Bœsch
On Thu, Nov 26, 2015 at 11:42:03PM +0100, Nicolas George wrote: > Le sextidi 6 frimaire, an CCXXIV, Clement Boesch a écrit : > > > An option can be added later to grant applications fine-grained control on > > > the looping, but it can not be the default as it would be an API change, > > > and >

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-26 Thread Clément Bœsch
On Thu, Nov 26, 2015 at 07:47:53PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavformat/utils.c | 2 ++ > 1 file changed, 2 insertions(+) > > > An option can be added later to grant applications fine-grained control on > the looping, but it can not

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-26 Thread Nicolas George
Le sextidi 6 frimaire, an CCXXIV, Clement Boesch a écrit : > > An option can be added later to grant applications fine-grained control on > > the looping, but it can not be the default as it would be an API change, and > > it probably should not be the default anyway. > > +if (ret ==

[FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-26 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/utils.c | 2 ++ 1 file changed, 2 insertions(+) An option can be added later to grant applications fine-grained control on the looping, but it can not be the default as it would be an API change, and it probably should not be the

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: handle AVERROR_REDO.

2015-11-26 Thread Michael Niedermayer
On Thu, Nov 26, 2015 at 07:47:53PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavformat/utils.c | 2 ++ > 1 file changed, 2 insertions(+) > > > An option can be added later to grant applications fine-grained control on > the looping, but it can not