Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-14 Thread Michael Niedermayer
On Thu, Mar 12, 2015 at 08:13:53PM +0100, Christophe Gisquet wrote: > Hi, > > 2015-03-11 17:06 GMT+01:00 James Almer : > > As discussed before, mmx, mmxext and sse functions that have also an sse2 > > version, and > > 3dnow/3dnowext functions that have also an sse version, have no reason to > >

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-13 Thread Ronald S. Bultje
Hi, On Fri, Mar 13, 2015 at 3:19 PM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > Hi, > > 2015-03-13 14:34 GMT+01:00 Michael Niedermayer : > >> They will not be used in any real world scenario. > > > > well it could be usefull in debuging in same cases > > especially if all mmx cod

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-13 Thread Christophe Gisquet
Hi, 2015-03-13 14:34 GMT+01:00 Michael Niedermayer : >> They will not be used in any real world scenario. > > well it could be usefull in debuging in same cases > especially if all mmx code is disabled on x86_64, for any single > function its not too likely I believe fate and proper bug reports a

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-13 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 01:06:23PM -0300, James Almer wrote: > On 11/03/15 11:29 AM, Christophe Gisquet wrote: > > Hi, > > > > 2015-03-11 15:20 GMT+01:00 Michael Niedermayer : > >> personally iam in favor of more things being tested, but iam fine > >> with either > > > > I'll see what the opinion

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-12 Thread Christophe Gisquet
Hi, 2015-03-11 17:06 GMT+01:00 James Almer : > As discussed before, mmx, mmxext and sse functions that have also an sse2 > version, and > 3dnow/3dnowext functions that have also an sse version, have no reason to > exist in an > x86_64 build. I think the reason may have been someone tinkering on

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-12 Thread Christophe Gisquet
2015-03-11 2:26 GMT+01:00 Michael Niedermayer : > this breaks > make libavcodec/dct-test > ... > LD libavcodec/dct-test > libavcodec/dct-test.o:(.rodata+0xe8): undefined reference to > `ff_xvid_idct_mmx' > libavcodec/dct-test.o:(.rodata+0x108): undefined reference to > `ff_xvid_idct_mmxext'

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-12 Thread James Almer
On 11/03/15 11:29 AM, Christophe Gisquet wrote: > Hi, > > 2015-03-11 15:20 GMT+01:00 Michael Niedermayer : >> personally iam in favor of more things being tested, but iam fine >> with either > > I'll see what the opinions are in ~30H then. It looks to be around > 4.5KB more data, which isn't huge

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-11 Thread Christophe Gisquet
Hi, 2015-03-11 15:20 GMT+01:00 Michael Niedermayer : > personally iam in favor of more things being tested, but iam fine > with either I'll see what the opinions are in ~30H then. It looks to be around 4.5KB more data, which isn't huge, and doesn't cause a noticeable increase in compile time. --

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-11 Thread Michael Niedermayer
On Wed, Mar 11, 2015 at 03:09:51PM +0100, Christophe Gisquet wrote: > 2015-03-11 2:26 GMT+01:00 Michael Niedermayer : > > this breaks > > make libavcodec/dct-test > > ... > > LD libavcodec/dct-test > > libavcodec/dct-test.o:(.rodata+0xe8): undefined reference to > > `ff_xvid_idct_mmx' > > lib

Re: [FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-10 Thread Michael Niedermayer
On Tue, Mar 10, 2015 at 11:11:52PM +, Christophe Gisquet wrote: > Also reduce the table duplication with SSE2 code, remove duplicated > macro parameters. > --- > libavcodec/x86/Makefile| 3 +- > libavcodec/x86/xvididct.asm| 450 - > libavcodec/x86/

[FFmpeg-devel] [PATCH 2/4] x86: xvid_idct: port MMX IDCT to yasm

2015-03-10 Thread Christophe Gisquet
Also reduce the table duplication with SSE2 code, remove duplicated macro parameters. --- libavcodec/x86/Makefile| 3 +- libavcodec/x86/xvididct.asm| 450 - libavcodec/x86/xvididct_init.c | 40 ++- libavcodec/x86/xvididct_mmx.c | 549