Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

2017-11-16 Thread Derek Buitenhuis
On 11/17/2017 12:32 AM, Devin Heitmueller wrote: > I don’t have strong feelings either way. I’m happy to jam this into a > subsequent cleanup patch if nobody has an objection (it’s just much easier > since I have about 15 commits after this one in my Git tree). Looks like nobody is bothered, in

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

2017-11-16 Thread James Almer
On 11/16/2017 9:22 PM, Derek Buitenhuis wrote: > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + >> audio_offset; >> +for (int x = 0; x < pkt.size; x += sample_size) { > > I realize this is C++, but I'm not su

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

2017-11-16 Thread Devin Heitmueller
> On Nov 16, 2017, at 7:22 PM, Derek Buitenhuis > wrote: > > On 11/16/2017 6:34 PM, Devin Heitmueller wrote: >> +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + >> audio_offset; >> +for (int x = 0; x < pkt.size; x += sample_size) { > > I realize this is C++

Re: [FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

2017-11-16 Thread Derek Buitenhuis
On 11/16/2017 6:34 PM, Devin Heitmueller wrote: > +uint8_t *audio_in = ((uint8_t *) audioFrameBytes) + > audio_offset; > +for (int x = 0; x < pkt.size; x += sample_size) { I realize this is C++, but I'm not sure if we still try to stick to our C style (aka no mixed

[FFmpeg-devel] [PATCH 2/6] decklink: Introduce support for capture of multiple audio streams

2017-11-16 Thread Devin Heitmueller
Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo pair per audio language). To support the existing use