Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-07 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 03:57:31PM +0100, Clément Bœsch wrote: > From: Clément Bœsch > > Fix a dead lock under certain conditions. Let's assume we have a queue of 1 > message max, 2 senders, and 1 receiver. [...] Pushed with commit message adjusted -- Clément B.

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-06 Thread Nicolas George
Le quintidi 15 frimaire, an CCXXIV, Clement Boesch a écrit : > This was before providing the 2 cond version, but OK Sorry, missed that. Patch looks good to me, but you forgot to update the commit message. > I'd like to push the test as well, but it depends on the first patch > (flush func). I

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-05 Thread Clément Bœsch
On Sat, Dec 05, 2015 at 01:19:16PM +0100, Nicolas George wrote: > Le quintidi 15 frimaire, an CCXXIV, Clement Boesch a écrit : > > ping, I'd like to apply this fix soon > > I have already answered: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/184285.html > This was before

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-05 Thread Nicolas George
Le quintidi 15 frimaire, an CCXXIV, Clement Boesch a écrit : > ping, I'd like to apply this fix soon I have already answered: http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/184285.html So please go ahead. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-05 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 03:57:31PM +0100, Clément Bœsch wrote: [...] > This second solution replaces the condition with two: one to notify the > senders, and one to notify the receivers. This prevents senders from > notifying other senders instead of a reader, and the other way around. > It also

[FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch Fix a dead lock under certain conditions. Let's assume we have a queue of 1 message max, 2 senders, and 1 receiver. Scenario (real record obtained with debug added): [...] SENDER #0: acquired lock SENDER #0: queue is full, wait SENDER

[FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch Fix a dead lock under certain conditions. Let's assume we have a queue of 1 message max, 2 senders, and 1 receiver. Scenario (real record obtained with debug added): [...] SENDER #0: acquired lock SENDER #0: queue is full, wait SENDER