Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2021-01-31 Thread Gyan Doshi
On 01-02-2021 06:05 am, Andreas Rheinhardt wrote: Moritz Barsnick: On Wed, Nov 25, 2020 at 00:47:46 +0100, Andreas Rheinhardt wrote: and therefore concluded that adding an APIChanges entry is appropriate; but I can of course also omit it. Is a version bump necessary? If yes, minor or micro?

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2021-01-31 Thread Andreas Rheinhardt
Moritz Barsnick: > On Wed, Nov 25, 2020 at 00:47:46 +0100, Andreas Rheinhardt wrote: >> and therefore concluded that adding an APIChanges entry is appropriate; >> but I can of course also omit it. >> Is a version bump necessary? If yes, minor or micro? > > I would say so - a change in options

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2021-01-31 Thread Moritz Barsnick
On Wed, Nov 25, 2020 at 00:47:46 +0100, Andreas Rheinhardt wrote: > and therefore concluded that adding an APIChanges entry is appropriate; > but I can of course also omit it. > Is a version bump necessary? If yes, minor or micro? I would say so - a change in options (and/or feature set) should

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-12-02 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-11-25 01:01:44) >One could write a decoder that decodes it That's almost a tautology ;) > I am not against just removing the option now. What do others think > about this? Kill it with fire. We should not allow creating invalid files, unless there are really

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Andreas Rheinhardt
Marton Balint: > > > On Tue, 24 Nov 2020, James Almer wrote: > >> On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: >>> This option just creates broken output because an MPEG-1 bitstream >>> can't signal whether MPEG-2 intra VLC tables have been used. > > If the output was really broken with

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Andreas Rheinhardt
James Almer: > On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: >> This option just creates broken output because an MPEG-1 bitstream >> can't signal whether MPEG-2 intra VLC tables have been used. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> Missing version bump. >> >>   doc/APIchanges 

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Marton Balint
On Tue, 24 Nov 2020, James Almer wrote: On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: This option just creates broken output because an MPEG-1 bitstream can't signal whether MPEG-2 intra VLC tables have been used. If the output was really broken with this option then IMHO the

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread James Almer
On 11/24/2020 11:41 AM, Andreas Rheinhardt wrote: This option just creates broken output because an MPEG-1 bitstream can't signal whether MPEG-2 intra VLC tables have been used. Signed-off-by: Andreas Rheinhardt --- Missing version bump. doc/APIchanges | 3 +++

[FFmpeg-devel] [PATCH 4/4] avcodec/mpeg12enc: Deprecate using MPEG-2 intra VLC table for mpeg1video

2020-11-24 Thread Andreas Rheinhardt
This option just creates broken output because an MPEG-1 bitstream can't signal whether MPEG-2 intra VLC tables have been used. Signed-off-by: Andreas Rheinhardt --- Missing version bump. doc/APIchanges | 3 +++ libavcodec/mpeg12enc.c | 7 +-- 2 files changed, 8 insertions(+), 2