Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread Michael Niedermayer
On Tue, Mar 30, 2021 at 02:30:08PM -0300, James Almer wrote: > On 3/30/2021 5:56 AM, Michael Niedermayer wrote: > > On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: > > > Current code is very confused and confusing. It uses two different > > > reference frames - "previous" and "last"

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread James Almer
On 3/30/2021 5:56 AM, Michael Niedermayer wrote: On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: Current code is very confused and confusing. It uses two different reference frames - "previous" and "last" - when only one is really necessary. It also confuses the two, leading to in

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread Michael Niedermayer
On Tue, Mar 30, 2021 at 10:56:13AM +0200, Michael Niedermayer wrote: > On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: > > Current code is very confused and confusing. It uses two different > > reference frames - "previous" and "last" - when only one is really > > necessary. It also

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-03-30 Thread Michael Niedermayer
On Tue, Feb 16, 2021 at 09:24:15PM +0100, Anton Khirnov wrote: > Current code is very confused and confusing. It uses two different > reference frames - "previous" and "last" - when only one is really > necessary. It also confuses the two, leading to incorrect output with > APNG_DISPOSE_OP_PREVIOUS

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-02-18 Thread Anton Khirnov
Quoting Paul B Mahol (2021-02-17 14:34:18) > On Wed, Feb 17, 2021 at 12:33 PM Anton Khirnov wrote: > > > Quoting Paul B Mahol (2021-02-17 11:52:31) > > > On Tue, Feb 16, 2021 at 9:26 PM Anton Khirnov wrote: > > > > @@ -1088,23 +1084,23 @@ static int handle_p_frame_apng(AVCodecContext > > > > *av

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-02-17 Thread Paul B Mahol
On Wed, Feb 17, 2021 at 12:33 PM Anton Khirnov wrote: > Quoting Paul B Mahol (2021-02-17 11:52:31) > > On Tue, Feb 16, 2021 at 9:26 PM Anton Khirnov wrote: > > > @@ -1088,23 +1084,23 @@ static int handle_p_frame_apng(AVCodecContext > > > *avctx, PNGDecContext *s, > > > if (!buffer) > > >

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-02-17 Thread Anton Khirnov
Quoting Paul B Mahol (2021-02-17 11:52:31) > On Tue, Feb 16, 2021 at 9:26 PM Anton Khirnov wrote: > > @@ -1088,23 +1084,23 @@ static int handle_p_frame_apng(AVCodecContext > > *avctx, PNGDecContext *s, > > if (!buffer) > > return AVERROR(ENOMEM); > > > > +ff_thread_await_progress

Re: [FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-02-17 Thread Paul B Mahol
On Tue, Feb 16, 2021 at 9:26 PM Anton Khirnov wrote: > Current code is very confused and confusing. It uses two different > reference frames - "previous" and "last" - when only one is really > necessary. It also confuses the two, leading to incorrect output with > APNG_DISPOSE_OP_PREVIOUS mode. >

[FFmpeg-devel] [PATCH 5/6] pngdec: fix and simplify apng reference handling

2021-02-16 Thread Anton Khirnov
Current code is very confused and confusing. It uses two different reference frames - "previous" and "last" - when only one is really necessary. It also confuses the two, leading to incorrect output with APNG_DISPOSE_OP_PREVIOUS mode. Fixes #9017. --- libavcodec/pngdec.c | 93