Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-23 Thread Kieran Kunhya
> > I agree with your guys. Can I submit a patch to remove AV_PIX_FMT_YUV422P, > it's not belong > to v210 encoder also? It make me misunderstanding it's acceptable to add > other format. > Nope, YUV422P is perfectly fine, it's the correct pixel format, there are no conversions from another

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-22 Thread Limin Wang
On Sun, Sep 22, 2019 at 07:15:53PM +0100, Derek Buitenhuis wrote: > On 22/09/2019 17:18, Kieran Kunhya wrote: > > And just like in the kernel, zero copy technology is maintained outside. > > Good design is separation of different functionality, otherwise the > > combinations of codepaths is

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-22 Thread Derek Buitenhuis
On 22/09/2019 17:18, Kieran Kunhya wrote: > And just like in the kernel, zero copy technology is maintained outside. > Good design is separation of different functionality, otherwise the > combinations of codepaths is exponentiated. Agreed with everyone else here, this code doesn't belong in an

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-22 Thread Michael Niedermayer
On Sat, Sep 21, 2019 at 10:49:21PM -0400, Devin Heitmueller wrote: > > > On Sep 21, 2019, at 4:44 PM, Michael Niedermayer > > wrote: > > > >> The patch just expands 4:2:0 to 4:2:2 while properly supporting interlaced > >> chroma. > > > > 4:2:0 and 4:2:2 have a chroma plane with different

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-22 Thread Kieran Kunhya
> > This means that several of your big-name experts should consider the > global design, > improve the current system framework, and solve the actual needs, rather > than simply > rejecting the performance improvement of different modules. I believe that > the kernel > zero copy technology is

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-22 Thread Limin Wang
On Sun, Sep 22, 2019 at 10:05:10AM +0200, Paul B Mahol wrote: > On 9/20/19, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210_template.c | 20 > > libavcodec/v210enc.c | 8 +--- > > 2 files changed,

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-22 Thread Paul B Mahol
On 9/20/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/v210_template.c | 20 > libavcodec/v210enc.c | 8 +--- > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/v210_template.c

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-21 Thread Devin Heitmueller
> On Sep 21, 2019, at 4:44 PM, Michael Niedermayer > wrote: > >> The patch just expands 4:2:0 to 4:2:2 while properly supporting interlaced >> chroma. > > 4:2:0 and 4:2:2 have a chroma plane with different resolution. > converting between planes of different resolution is what i called

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-21 Thread Michael Niedermayer
On Fri, Sep 20, 2019 at 03:19:52PM -0400, Devin Heitmueller wrote: > Hello Michael, > > > > On Sep 20, 2019, at 12:10 PM, Michael Niedermayer > > wrote: > > > > On Fri, Sep 20, 2019 at 11:55:17PM +0800, lance.lmw...@gmail.com wrote: > >> From: Limin Wang > >> > >> Signed-off-by: Limin Wang

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-20 Thread Limin Wang
On Fri, Sep 20, 2019 at 06:10:59PM +0200, Michael Niedermayer wrote: > On Fri, Sep 20, 2019 at 11:55:17PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/v210_template.c | 20 > > libavcodec/v210enc.c

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-20 Thread Devin Heitmueller
Hello Michael, > On Sep 20, 2019, at 12:10 PM, Michael Niedermayer > wrote: > > On Fri, Sep 20, 2019 at 11:55:17PM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavcodec/v210_template.c | 20 >> libavcodec/v210enc.c

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-20 Thread Michael Niedermayer
On Fri, Sep 20, 2019 at 11:55:17PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/v210_template.c | 20 > libavcodec/v210enc.c | 8 +--- > 2 files changed, 25 insertions(+), 3 deletions(-) Adding a

[FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/v210_template.c | 20 libavcodec/v210enc.c | 8 +--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/libavcodec/v210_template.c b/libavcodec/v210_template.c index 9e1d9f9..083a9f1 100644