Re: [FFmpeg-devel] [PATCH v2] Replace arrays of pointers to strings by arrays of strings

2021-01-12 Thread Reimar Döffinger
> On 12 Jan 2021, at 02:41, Andreas Rheinhardt > wrote: > Of course I am all ears for how to make it clear that someone who > modifies the strings also needs to check the array dimensions. I think I kind of agree with the other comments, this would/should rather have to be something that can

Re: [FFmpeg-devel] [PATCH v2] Replace arrays of pointers to strings by arrays of strings

2021-01-11 Thread Andreas Rheinhardt
Marton Balint: > > > On Wed, 6 Jan 2021, Andreas Rheinhardt wrote: > >> When the difference of the longest size and the average size of >> collection of strings is smaller than the size of a pointer, it makes >> sense to store the strings directly in an array instead of using an >> array of

Re: [FFmpeg-devel] [PATCH v2] Replace arrays of pointers to strings by arrays of strings

2021-01-06 Thread Mark Thompson
On 06/01/2021 09:34, Marton Balint wrote: On Wed, 6 Jan 2021, Andreas Rheinhardt wrote: When the difference of the longest size and the average size of collection of strings is smaller than the size of a pointer, it makes sense to store the strings directly in an array instead of using an array

Re: [FFmpeg-devel] [PATCH v2] Replace arrays of pointers to strings by arrays of strings

2021-01-06 Thread Marton Balint
On Wed, 6 Jan 2021, Andreas Rheinhardt wrote: When the difference of the longest size and the average size of collection of strings is smaller than the size of a pointer, it makes sense to store the strings directly in an array instead of using an array of pointers to strings (unless doing so

[FFmpeg-devel] [PATCH v2] Replace arrays of pointers to strings by arrays of strings

2021-01-06 Thread Andreas Rheinhardt
When the difference of the longest size and the average size of collection of strings is smaller than the size of a pointer, it makes sense to store the strings directly in an array instead of using an array of pointers to strings (unless doing so precludes deduplicating strings); doing so also