Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 7:10 PM, Lynne wrote: Mar 12, 2021, 21:00 by jamr...@gmail.com: On 3/12/2021 4:42 PM, Michael Niedermayer wrote: Related to this, what do the flags passed into get_encoder_buffer() mean exactly ? are they "hints" so that a new/unknown flag can be ignored by an implementation

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Lynne
Mar 12, 2021, 21:00 by jamr...@gmail.com: > On 3/12/2021 4:42 PM, Michael Niedermayer wrote: > >> >> Related to this, what do the flags passed into get_encoder_buffer() mean >> exactly ? >> are they "hints" so that a new/unknown flag can be ignored by an >> implementation >> or what else shoul

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Mark Thompson
On 22/02/2021 22:27, James Almer wrote: On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 04:59:16PM -0300, James Almer wrote: > On 3/12/2021 4:46 PM, James Almer wrote: > > On 3/12/2021 4:30 PM, Michael Niedermayer wrote: > > > On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: > > > > On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > > > > > On Thu,

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Michael Niedermayer: >> On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: >>> On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: > On 3/10/2021 5:18 PM, Michael Niedermayer wrote: >> On Mon, Feb

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 5:11 PM, Andreas Rheinhardt wrote: James Almer: On 3/12/2021 4:46 PM, James Almer wrote: On 3/12/2021 4:30 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:3

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Andreas Rheinhardt
James Almer: > On 3/12/2021 4:46 PM, James Almer wrote: >> On 3/12/2021 4:30 PM, Michael Niedermayer wrote: >>> On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 4:42 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 08:30:23PM +0100, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 4:46 PM, James Almer wrote: On 3/12/2021 4:30 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3/11/2021 1:35 PM, Michael Ni

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 4:30 PM, Michael Niedermayer wrote: On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 08:30:23PM +0100, Michael Niedermayer wrote: > On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: > > On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > > > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: > > > > On 3/11/2021 1:35 PM, Michael Niedermay

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Fri, Mar 12, 2021 at 02:03:52PM -0300, James Almer wrote: > On 3/12/2021 1:32 PM, Michael Niedermayer wrote: > > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: > > > On 3/11/2021 1:35 PM, Michael Niedermayer wrote: > > > > On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread James Almer
On 3/12/2021 1:32 PM, Michael Niedermayer wrote: On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: On 3/10/2021 5:18 PM, Michael Niedermayer wrote: On Mon, Feb 22, 2021 at

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: >> On 3/11/2021 1:35 PM, Michael Niedermayer wrote: >>> On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: On 3/10/2021 5:18 PM, Michael Niedermayer wrote: > On Mon, Feb 22, 2021 at 07:27:34PM -03

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-12 Thread Michael Niedermayer
On Thu, Mar 11, 2021 at 02:18:36PM -0300, James Almer wrote: > On 3/11/2021 1:35 PM, Michael Niedermayer wrote: > > On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: > > > On 3/10/2021 5:18 PM, Michael Niedermayer wrote: > > > > On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-11 Thread James Almer
On 3/11/2021 1:35 PM, Michael Niedermayer wrote: On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: On 3/10/2021 5:18 PM, Michael Niedermayer wrote: On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote: On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thomp

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-11 Thread Michael Niedermayer
On Wed, Mar 10, 2021 at 05:59:11PM -0300, James Almer wrote: > On 3/10/2021 5:18 PM, Michael Niedermayer wrote: > > On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote: > > > On 2/21/2021 6:04 PM, James Almer wrote: > > > > On 2/21/2021 5:29 PM, Mark Thompson wrote: > > > > > On 21/02/2021

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-10 Thread James Almer
On 3/10/2021 5:18 PM, Michael Niedermayer wrote: On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote: On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 1

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-10 Thread Michael Niedermayer
On Mon, Feb 22, 2021 at 07:27:34PM -0300, James Almer wrote: > On 2/21/2021 6:04 PM, James Almer wrote: > > On 2/21/2021 5:29 PM, Mark Thompson wrote: > > > On 21/02/2021 20:00, James Almer wrote: > > > > On 2/21/2021 4:13 PM, Mark Thompson wrote: > > > > > On 21/02/2021 17:35, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-08 Thread James Almer
On 3/8/2021 5:48 PM, Lynne wrote: Mar 8, 2021, 21:31 by jamr...@gmail.com: On 2/22/2021 7:27 PM, James Almer wrote: Looked at bit into this. AVCodec->encode2() based encoders don't support returning EAGAIN at all, as it completely breaks the frame threading logic. It would require a consid

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-08 Thread Lynne
Mar 8, 2021, 21:31 by jamr...@gmail.com: > On 2/22/2021 7:27 PM, James Almer wrote: > >> >> Looked at bit into this. AVCodec->encode2() based encoders don't support >> returning EAGAIN at all, as it completely breaks the frame threading logic. >> It would require a considerable rewrite in order

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-08 Thread James Almer
On 2/22/2021 7:27 PM, James Almer wrote: On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-22 Thread James Almer
On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implement

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Lynne
Feb 21, 2021, 22:04 by jamr...@gmail.com: > On 2/21/2021 5:29 PM, Mark Thompson wrote: > >> On 21/02/2021 20:00, James Almer wrote: >> >>> On 2/21/2021 4:13 PM, Mark Thompson wrote: >>> On 21/02/2021 17:35, James Almer wrote: > This callback is functionally the same as get_buffer2()

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Mark Thompson
On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user co

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Mark Thompson
On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by: James Almer --- Used the names Lynne

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
On 2/21/2021 2:59 PM, Lynne wrote: Feb 21, 2021, 18:35 by jamr...@gmail.com: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by:

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread Lynne
Feb 21, 2021, 18:35 by jamr...@gmail.com: > This callback is functionally the same as get_buffer2() is for decoders, and > implements for the new encode API the functionality of the old encode API had > where the user could provide their own buffers. > > Signed-off-by: James Almer > --- > Used th

[FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-02-21 Thread James Almer
This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by: James Almer --- Used the names Lynne suggested this time, plus a line about how