Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

2018-04-16 Thread Timo Teras
On Tue, 17 Apr 2018 00:01:42 +0100 Rostislav Pehlivanov wrote: > On 16 April 2018 at 15:05, Timo Teras wrote: > > > On Mon, 16 Apr 2018 10:53:43 -0300 > > James Almer wrote: > > > > > On 4/14/2018 3:32 PM, Timo Teräs wrote: > > >

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

2018-04-16 Thread Rostislav Pehlivanov
On 16 April 2018 at 15:05, Timo Teras wrote: > On Mon, 16 Apr 2018 10:53:43 -0300 > James Almer wrote: > > > On 4/14/2018 3:32 PM, Timo Teräs wrote: > > > Fixes https://trac.ffmpeg.org/ticket/2798 > > > > > > This makes movenc handle

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

2018-04-16 Thread Timo Teras
On Mon, 16 Apr 2018 10:53:43 -0300 James Almer wrote: > On 4/14/2018 3:32 PM, Timo Teräs wrote: > > Fixes https://trac.ffmpeg.org/ticket/2798 > > > > This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write > > the associated pictures in iTunes cover atom. This

Re: [FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

2018-04-16 Thread James Almer
On 4/14/2018 3:32 PM, Timo Teräs wrote: > Fixes https://trac.ffmpeg.org/ticket/2798 > > This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write > the associated pictures in iTunes cover atom. This corresponds > to how 'mov' demuxer parses and exposes the cover images when > reading. > >

[FFmpeg-devel] [PATCH v2] avformat/movenc: support writing iTunes cover image

2018-04-14 Thread Timo Teräs
Fixes https://trac.ffmpeg.org/ticket/2798 This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write the associated pictures in iTunes cover atom. This corresponds to how 'mov' demuxer parses and exposes the cover images when reading. Most of the existing track handling loops properly ignore