Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

2021-02-20 Thread James Almer
On 2/20/2021 9:20 PM, Andreas Rheinhardt wrote: James Almer: On 2/20/2021 8:41 PM, Lynne wrote: Feb 20, 2021, 21:53 by jamr...@gmail.com: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

2021-02-20 Thread Andreas Rheinhardt
Lynne: > Feb 21, 2021, 01:10 by jamr...@gmail.com: > >> On 2/20/2021 8:41 PM, Lynne wrote: >> >>> Maybe mention thread safety? Since in a frame-threaded encoder >>> this may be called from different threads. >>> >> >> So copy paste the paragraph "If frame multithreading is used, this callback >>

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

2021-02-20 Thread Lynne
Feb 21, 2021, 01:10 by jamr...@gmail.com: > On 2/20/2021 8:41 PM, Lynne wrote: > >> Maybe mention thread safety? Since in a frame-threaded encoder >> this may be called from different threads. >> > > So copy paste the paragraph "If frame multithreading is used, this callback > may be called from

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

2021-02-20 Thread Andreas Rheinhardt
James Almer: > On 2/20/2021 8:41 PM, Lynne wrote: >> Feb 20, 2021, 21:53 by jamr...@gmail.com: >> >>> This callback is functionally the same as get_buffer2() is for >>> decoders, and >>> implements for the new encode API the functionality of the old encode >>> API had >>> where the user could provi

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

2021-02-20 Thread James Almer
On 2/20/2021 8:41 PM, Lynne wrote: Feb 20, 2021, 21:53 by jamr...@gmail.com: This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by:

Re: [FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

2021-02-20 Thread Lynne
Feb 20, 2021, 21:53 by jamr...@gmail.com: > This callback is functionally the same as get_buffer2() is for decoders, and > implements for the new encode API the functionality of the old encode API had > where the user could provide their own buffers. > > Signed-off-by: James Almer > --- > As sugg

[FFmpeg-devel] [RFC][PATCH] avcodec: add a get_enc_buffer() callback to AVCodecContext

2021-02-20 Thread James Almer
This callback is functionally the same as get_buffer2() is for decoders, and implements for the new encode API the functionality of the old encode API had where the user could provide their own buffers. Signed-off-by: James Almer --- As suggested by Anton, here's get_buffer() for encoders. This w